Chart: Set --enable-metrics depending on controller.metrics.enabled.

[Gacko]

Credits to @pmint93 (#10070)!

What this PR does / why we need it:

The chart has a value controller.metrics.enabled which gives the impression of enabling or disabling the metrics collection of the controller. Actually it only controls the exposition of the metrics port to the cluster and some other resources around metrics collection, but does not enable or disable the metrics collection inside the controller.

This PR sets the --enable-metrics argument to false if controller.metrics.enabled is false, which is the default.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	8defaa9
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65bc1cc2c3b2ba0008d26dcb

[Gacko]

/assign @strongjz
/kind bug
/priority backlog
/triage accepted

[Gacko]

I will rework the CI tests in the ci/ directory in a different PR and also include tests for this use case there.

[ubergesundheit]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, ubergesundheit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko,ubergesundheit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

/cherry-pick release-1.9

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #10961

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[NeckBeardPrince]

This was not a Kustomize friendly change. 😮‍💨

[strongjz]

@NeckBeardPrince please open an issue and explain the issue. Thank you.