[helm] configure allow to configure hostAliases

[jkroepke]

What this PR does / why we need it:

This PR allows to configure the hostAliases property for an pod.

The hostAliases property allows to add hostname to the /etc/hosts.

I would like to use this in combination with nginx.ingress.kubernetes.io/auth-url: "https://$host/api/auth/keys".

By default, ingress-nginx it call a URL on the same domain. Since the domain points to an external DNS, ingress-nginx do create an ingress over Internet Gateway, back to the Public LB and passed again to the same ingress-nginx instance.

To avoid the loop, I would like to put some domains into the hostAlias property to overwrite the DNS entry with 127.0.0.1

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @jkroepke. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	5c3ec31
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64a5d7250b06ff0008d608b9

[rikatz]

/ok-to-test

[jkroepke]

@rikatz this is okay and we can continue the process here?

[jkroepke]

@rikatz Could you take a look here?

I have misclicked and re-open this PR.

[jkroepke]

@rikatz I would appreciate a review here.

[tao12345666333]

/lgtm

thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkroepke, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

And again... missing in DaemonSet. Would be nice to take more care about implementing such changes in both, the Deployment and the DaemonSet. :)

[jkroepke]

it would be really nice if deployment and daemonset could share the same pod template ... like on the grafana chart to prevent this...

[Gacko]

Yes, probably. Actually this was less of a criticism and rather a possible improvement for the review. It's basically the same for the controller-service.yaml and controller-service-internal.yaml. I still have a PR open for aligning Deployment with DaemonSet and both services.