Deployment/DaemonSet: Fix templating & value.

[Gacko]

What this PR does / why we need it:

This PR fixes the templating of Deployment & DaemonSet and the type of controller.hostAliases in the values.yaml which should be an array.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	e92250e
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64fb047e314bd30008b80ba4

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @Gacko. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Gacko]

@strongjz: I created this PR in favor of #9744 since the base repository changed.

[Gacko]

@tao12345666333 This one also fixes an issue introduced in #10180. The PR added hostAliases to the Deployment, but not to the DaemonSet, and uses an object in the values.yaml while the pod template expects it to be an array (see the docs).

[tao12345666333]

Thank you for your contribution, I left one comment

[tao12345666333]

#10240 (comment)

[Gacko]

I removed the explicit distroloss argument from the extraModules section.

[Gacko]

@tao12345666333 I removed the distroless argument from the normal extra modules section as you proposed. Is there anything else preventing this PR from getting merged? Can I support you somewhere? :)

[tao12345666333]

sorry for the delay. Only one comment, others LGTM

[tao12345666333]

sorry for the delay.

I think it can be merged.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment