-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Tests: Explicitly enable metrics. #10962
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
I did not change the other values here as there test cases do not need metrics. |
/cherry-pick release-1.9 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, rikatz, ubergesundheit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Gacko: new pull request created: #10965 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
PR #10959 sets
--enable-metrics
tofalse
by default, but we need the metrics in the E2E tests, so this PR explicitly enables them again.Types of changes
Checklist: