Chart: Add controller.metrics.service.enabled.

[LeMyst]

What this PR does / why we need it:

Add support to disable the controller metrics service, because sometimes we don't need to have the service exposed cluster-wide, like you have a local agent on the node (like datadog agent)
So a new values in created: controller.metrics.service.enabled.
Allow to have the same behaviour as before chart v4.10.0 and #10959
So you can have metrics enabled on nginx but no service created.
Default is to have the service created if the controller metrics part is enabled, so there is no regression.
Updated the test to reflect the changes.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

No Issue created.

How Has This Been Tested?

Modified the chart on my non-production environement and confirm we got the same behaviour as before chart 4.10.0.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

• ✅login: LeMyst / (ced332b)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @LeMyst!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @LeMyst. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	ced332b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66faca7a5face10008fa4c9f

[Gacko]

/retitle Chart: Add controller.metrics.service.enabled.
/triage accepted
/kind feature
/priority backlog
/assign
/hold

Basically looks fine, gonna have another look and leave some suggestions later.

[Gacko]

Done. We can merge as soon as you signed the CLA.

[Gacko]

/ok-to-test
/lgtm

[LeMyst]

Done. We can merge as soon as you signed the CLA.

Hello @Gacko ,
I am trying to find out how the personal data provided when signing the CLA is managed, do you know where I can read them?
Because I am wondering who can have access to the data provided.

Thank you,

BR

[Gacko]

Hello @LeMyst,

unfortunately I don't know this. Have you checked the Privacy Policy of the Linux Foundation?

@strongjz @rikatz @cpanato Do you happen to know something about this?

Regards
Marco

[strongjz]

No, but here are the directions, and you can read more in the docusign before signing it.

https://docs.linuxfoundation.org/lfx/easycla/v2-current/contributors/individual-contributor

[strongjz]

Here's the privacy policy https://www.linuxfoundation.org/legal/privacy-policy

[strongjz]

I asked in sig-contribex

https://kubernetes.slack.com/archives/C1TU9EB9S/p1727725710388669

[LeMyst]

Here's the privacy policy https://www.linuxfoundation.org/legal/privacy-policy

More specific about the EasyCLA process:
https://www.linuxfoundation.org/legal/lfx-privacy-policy-addendum "LFX EasyCLA" section

Thank you and @Gacko

[Gacko]

/lgtm
/unhold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, LeMyst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment