-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated testrunner image sha to new image with ginkgo bumped to v2.5.1 #9340
updated testrunner image sha to new image with ginkgo bumped to v2.5.1 #9340
Conversation
/triage accepted |
/lgtm Builds should pass, thanks for tracking this one done. I'll add it to the list. |
1 similar comment
/lgtm Builds should pass, thanks for tracking this one done. I'll add it to the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, strongjz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
make kind-e2e-test
is broken because go.mod has ginkgo v2.5.1 Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.1 #9317 , whereas ginkgo version is hardcoded to v2.1.4 in scripts. So expecting this updated image to contribute towards fix for problems described in fixed multiple ginkgo versions #9336Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook