Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed multiple ginkgo versions #9336

Merged
merged 1 commit into from
Nov 25, 2022
Merged

fixed multiple ginkgo versions #9336

merged 1 commit into from
Nov 25, 2022

Conversation

longwuyuan
Copy link
Contributor

@longwuyuan longwuyuan commented Nov 25, 2022

What this PR does / why we need it:

  • ginkgo version was changed in /go.mod Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.1 #9317
    , without changing the hardcoded ginkgo version in the project's scripts
  • This PR tries to set the ginkgo version to v2.5.1, in the scripts/code, where ginkgo version is hardcoded, to be consistent with the change in /go.mod
  • In future, we should use this PR to understand, what files & lines to edit, for bumping ginkgo version in the project
  • This will create new test-runner image, that will need to be promoted asap, to make progress on make kind-e2e-test should generate junit reports #9321
  • Discovered this while running make kind-e2e-test
  • After this PR, there are ginkgo feature deprecations, that need to be addressed in a follow-up PR. Example
You're using deprecated Ginkgo functionality:             
=============================================             
  --ginkgo.progress is deprecated .  The functionality provided by --progress was confusing and is no longer needed.  Use --show-node-events instead to see node entry and exit events included in the timeline of failed and verbose spe
cs.  Or you can run with -vv to always see all node events.  Lastly, --poll-progress-after and the PollProgressAfter decorator now provide a better mechanism for debugging specs that tend to get stuck.
  --ginkgo.slow-spec-threshold is deprecated --slow-spec-threshold has been deprecated and will be removed in a future version of Ginkgo.  This feature has proved to be more noisy than useful.  You can use --poll-progress-after, inst
ead, to get more actionable feedback about potentially slow specs and understand where they might be getting stuck.

To silence deprecations that can be silenced set the following environment variable:                                
  ACK_GINKGO_DEPRECATIONS=2.5.1  

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

  • Tested locally. Non-functional tests are running

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

fixed multiple ginkgo versions

/triage accepted
/area stabilization

/assign @rikatz @tao12345666333

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added area/stabilization Work for increasing stabilization of the ingress-nginx codebase cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@strongjz
Copy link
Member

I hate our build sometimes, sorry @longwuyuan I blindly approved the dependabot pr.

@strongjz strongjz merged commit 04ce923 into kubernetes:main Nov 25, 2022
@longwuyuan
Copy link
Contributor Author

Aah, I got to learn tons and now I know what not to do. So thank you for being teacher/mentor yet again :-)

@longwuyuan
Copy link
Contributor Author

/kind bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/stabilization Work for increasing stabilization of the ingress-nginx codebase cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants