Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added slim-sprig and pprof indirect dependency libs #9343

Closed
wants to merge 1 commit into from
Closed

added slim-sprig and pprof indirect dependency libs #9343

wants to merge 1 commit into from

Conversation

longwuyuan
Copy link
Contributor

@longwuyuan longwuyuan commented Nov 26, 2022

What this PR does / why we need it:

% git diff
diff --git a/go.mod b/go.mod
index 91bda5845..329bdb6dc 100644
--- a/go.mod
+++ b/go.mod
@@ -70,6 +70,7 @@ require (
        github.com/go-openapi/jsonpointer v0.19.5 // indirect
        github.com/go-openapi/jsonreference v0.19.5 // indirect
        github.com/go-openapi/swag v0.19.14 // indirect
+       github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 // indirect
        github.com/godbus/dbus/v5 v5.0.6 // indirect
        github.com/gogo/protobuf v1.3.2 // indirect
        github.com/golang-jwt/jwt/v4 v4.2.0 // indirect
@@ -80,6 +81,7 @@ require (
        github.com/google/gnostic v0.5.7-v3refs // indirect
        github.com/google/go-cmp v0.5.9 // indirect
        github.com/google/gofuzz v1.1.0 // indirect
+       github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1 // indirect
        github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
        github.com/google/uuid v1.2.0 // indirect
        github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7 // indirect
diff --git a/go.sum b/go.sum
index f53cec3a6..1a2c91f5c 100644
--- a/go.sum
+++ b/go.sum
@@ -167,6 +167,8 @@ github.com/go-openapi/swag v0.19.5/go.mod h1:POnQmlKehdgb5mhVOsnJFsivZCEZ/vjK9gh
 github.com/go-openapi/swag v0.19.14 h1:gm3vOOXfiuw5i9p5N9xJvfjvuofpyvLA9Wr6QfK5Fng=
 github.com/go-openapi/swag v0.19.14/go.mod h1:QYRuS/SOXUCsnplDa677K7+DxSOj6IPNl/eQntq43wQ=
 github.com/go-stack/stack v1.8.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
+github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 h1:p104kn46Q8WdvHunIJ9dAyjPVtrBPhSr3KT2yUst43I=
+github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg7847qk6SyHyPtNmDHnmrv/HOrqktSC+C9fM+CJOE=
 github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
 github.com/godbus/dbus/v5 v5.0.6 h1:mkgN1ofwASrYnJ5W6U/BxG15eXXXjirgZc7CLqkcaro=
 github.com/godbus/dbus/v5 v5.0.6/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
@@ -252,6 +254,7 @@ github.com/google/pprof v0.0.0-20210122040257-d980be63207e/go.mod h1:kpwsk12EmLe
 github.com/google/pprof v0.0.0-20210226084205-cbba55b83ad5/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/google/pprof v0.0.0-20210601050228-01bbb1931b22/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/google/pprof v0.0.0-20210609004039-a478d1d731e9/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
+github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1 h1:K6RDEckDVWvDI9JAJYCmNdQXq6neHJOYx3V6jnqNEec=
 github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
 github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 h1:El6M4kTTCOh6aBiKaUGG7oYTSPP8MxqL4YI3kZKwcP4=

  • The reason is based around reasons explained in fixed multiple ginkgo versions #9336
  • Now we figured out the root-cause why the files go.mod & go.sum change. The new dependecies are a indirect dependency of ginkgo v2.5.1
% go mod graph | grep -i slim-sprig
k8s.io/ingress-nginx github.com/go-task/[email protected]
github.com/go-task/[email protected] github.com/davecgh/[email protected]
github.com/go-task/[email protected] github.com/stretchr/[email protected]
github.com/onsi/ginkgo/[email protected] github.com/go-task/[email protected]
  • Similarly for the pprof package
% go mod graph | grep -i pprof | grep cloud
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
cloud.google.com/[email protected] github.com/google/[email protected]
  • This PR adds those 2 libs, "slim-sprig" & "pprof", to go.mod and hence to go.sum as well

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #9342

How Has This Been Tested?

  • Tested locally with make kind e2e-test

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

added slim-sprig and pprof indirect dependency libs

/triage accepted
/area stabilization
/priority important-soon

/assign @rikatz @tao12345666333

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/stabilization Work for increasing stabilization of the ingress-nginx codebase priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: longwuyuan
Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval by writing /assign @tao12345666333 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2022
@tao12345666333
Copy link
Member

let me try.

@longwuyuan
Copy link
Contributor Author

@tao12345666333 , dependabot bumped crypto in #9318 and slim-sprig is a package that is "slim' because it seems to strip "crypto" related packages from sprig. This is as per the README of slim-sprig https://github.com/go-task/slim-sprig. I know for sure we merged PRs that changed some templates recently and slim-sprig is a library for functions that get used in templates. I could be 100% wrong.

@tao12345666333
Copy link
Member

I can't reproduce this issue.

@longwuyuan longwuyuan closed this Nov 30, 2022
@longwuyuan longwuyuan deleted the issue-9342 branch November 30, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod needs 2 new indirect dependencies
4 participants