-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dns cache for k8s-infra-prow-build, cleanup gke-cluster module #1686
Conversation
- shorter name - add description noting deploy fun, include link - drop TODO to drop the option once aaa migrated over
It's being deprecated upstream this release cycle
/cc @chaodaiG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold
Do we also need to specify minimum terraform version so that the changes from this PR always work?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel
We use version constraints in the individual clusters, e.g. k8s.io/infra/gcp/clusters/projects/k8s-infra-prow-build/prow-build/00-provider.tf Lines 8 to 20 in e5f748a
But, you're right, there are definite gaps:
|
Ran
Since nodes need to be recreated for this to take effect, I would rather batch this up with upgrading the cluster to v1.17 |
#1541 (comment) - upgrading node pool now, this will take some time to complete, will verify whether addon has deployed afterward |
Followup to #1680 which added the dns cache option, and enabled for k8s-infra-prow-build-trusted
I did some cleanup while I was here, see commits for details