Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dns cache for k8s-infra-prow-build, cleanup gke-cluster module #1686

Merged
merged 3 commits into from
Feb 19, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Feb 19, 2021

Followup to #1680 which added the dns cache option, and enabled for k8s-infra-prow-build-trusted

I did some cleanup while I was here, see commits for details

- shorter name
- add description noting deploy fun, include link
- drop TODO to drop the option once aaa migrated over
It's being deprecated upstream this release cycle
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 19, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Feb 19, 2021

/cc @chaodaiG
you opened previous pr
/cc @michelle192837
test-infra-oncall

Copy link
Contributor

@chaodaiG chaodaiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/hold
Do we also need to specify minimum terraform version so that the changes from this PR always work?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Feb 19, 2021

/hold cancel

Do we also need to specify minimum terraform version so that the changes from this PR always work

We use version constraints in the individual clusters, e.g.

terraform {
required_version = "~> 0.12.20"
backend "gcs" {
bucket = "k8s-infra-clusters-terraform"
prefix = "k8s-infra-prow-build/prow-build" // $project_name/$cluster_name
}
required_providers {
google = "~> 3.46.0"
google-beta = "~> 3.46.0"
}
}

But, you're right, there are definite gaps:

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7d1017f into kubernetes:main Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 19, 2021
@spiffxp spiffxp deleted the prow-build-dns-cache branch February 19, 2021 18:24
@spiffxp
Copy link
Member Author

spiffxp commented Feb 19, 2021

Ran terraform apply, timestamps for updates to the control plane

$ gcloud container operations list --project=k8s-infra-prow-build --filter="startTime>='2021-02-19'" --format="table(startTime,endTime,operationType,name,status)"
START_TIME                      END_TIME                        TYPE            NAME                              STATUS
2021-02-19T17:29:29.862954192Z  2021-02-19T17:29:30.046259487Z  UPDATE_CLUSTER  operation-1613755769862-3158504f  DONE
2021-02-19T17:29:40.181746963Z  2021-02-19T17:57:21.542807273Z  UPDATE_CLUSTER  operation-1613755780181-48a49af1  DONE

Since nodes need to be recreated for this to take effect, I would rather batch this up with upgrading the cluster to v1.17

@spiffxp
Copy link
Member Author

spiffxp commented Feb 19, 2021

#1541 (comment) - upgrading node pool now, this will take some time to complete, will verify whether addon has deployed afterward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants