Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custon kube-dns-autoscaler configmap to prow build clusters #1691

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Add custon kube-dns-autoscaler configmap to prow build clusters #1691

merged 2 commits into from
Feb 22, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Feb 22, 2021

Now that node local dns cache is enabled for prow build clusters, we want to adjust the configmap used to autoscale dns servers. This is as requested in kubernetes/test-infra#20716 (comment)

This should be the last bit of work related to enabling node local dns cache to prow build clusters:

This should hopefully address:

@spiffxp
Add kube-dns-autoscaler-configmap to prow clusters
7eae134 
These are the defaults as retrieved from the clusters today
@spiffxp
Update kube-dns-autoscaler configmap
d2d14a9 
These are the values that have been used on other prow clusters
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Feb 22, 2021

/uncc @stevekuznetsov @alejandrox1
/cc @BenTheElder
you opened kubernetes/test-infra#20816
/cc @jprzychodzen @mborsz
you opened kubernetes/test-infra#20716
/cc @chaodaiG
you've suggested this as a possible fix to both
/cc @michelle192837
go.k8s.io/oncall
/cc @ameukam
k8s-infra-prow-oncall

@spiffxp
Copy link
Member Author

spiffxp commented Feb 22, 2021

I'm explicitly not using the "fixes" keywords so we can wait to confirm these changes have resolved the issues in question

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
chaodaiG
chaodaiG approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@chaodaiG chaodaiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

/hold
In case you want to wait for more reviews

...k8s-infra-prow-build-trusted/prow-build-trusted/resources/kube-dns-autoscaler-configmap.yaml
# This is to address a known issue with node local dns cache
# https://cloud.google.com/kubernetes-engine/docs/how-to/nodelocal-dns-cache#known_issues
# TODO: remove when cluster version is >= 1.19.7-gke.1500
# NOTE: string containing structured data, was retrieved from v1.17.15-gke.800, may fail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related kubernetes-sigs/cluster-proportional-autoscaler#97

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Feb 22, 2021

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Feb 22, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit df113b2 into kubernetes:main Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 22, 2021
@spiffxp spiffxp deleted the prow-kube-dns-configmap branch February 22, 2021 17:27
@spiffxp spiffxp mentioned this pull request Feb 22, 2021
Closed
@BenTheElder
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG chaodaiG approved these changes

@ameukam ameukam Awaiting requested review from ameukam

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@jprzychodzen jprzychodzen Awaiting requested review from jprzychodzen

@mborsz mborsz Awaiting requested review from mborsz

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@ameukam ameukam

@chaodaiG chaodaiG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@spiffxp @k8s-ci-robot @ameukam @BenTheElder @chaodaiG