Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-api repo #135

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2018
@nikhita
Copy link
Member Author

nikhita commented Nov 21, 2018

/hold

Adding hold because:

  1. This PR should not be merged until Add node-api staging repo w/ RuntimeClass API kubernetes#67791 gets merged in k/k.
  2. Once the PR gets merged, we should verify that the dependencies are the same as that currently in the PR.

I'll consider it safe to remove the hold once both these items have been done and verified.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2018
@sttts
Copy link
Contributor

sttts commented Nov 21, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2018
@tallclair
Copy link
Member

kubernetes/kubernetes#67791 finally merged. Aside from the non-kubernetes dependencies, there are a few others under k8s.io:

k8s.io/klog
k8s.io/kube-openapi

None of those are in staging though. Is it only the staging deps that matter here?

@nikhita
Copy link
Member Author

nikhita commented Dec 20, 2018

Is it only the staging deps that matter here?

Yes. 👍

kubernetes/kubernetes#67791 finally merged.

Yay! :)

Verified that the dependencies are correct. Cancelling the hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2018
@nikhita
Copy link
Member Author

nikhita commented Dec 20, 2018

@tallclair The repo will get populated once @sttts deploys this change.

@k8s-ci-robot k8s-ci-robot merged commit 570ff31 into kubernetes:master Dec 20, 2018
@sttts
Copy link
Contributor

sttts commented Dec 20, 2018

Bot is redeployed. Let's hope everything goes well 🙏

@nikhita nikhita deleted the add-node-api-repo branch December 21, 2018 10:37
@nikhita
Copy link
Member Author

nikhita commented Dec 21, 2018

https://github.com/kubernetes/node-api has been published successfully! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants