-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new github.com/kubernetes/node-api repo #38
Comments
@tallclair So your intention here is to have another staging repo that the publishing bot can push to? |
Right - I'm adding a new Proposed implementation is in kubernetes/kubernetes#67791. We should confirm that this is the pattern we want new APIs to follow though. Commented on https://groups.google.com/d/msg/kubernetes-sig-storage-wg-csi/x5CchIP9qiI/cqkt2oH3DQAJ to follow up. |
@tallclair any update on this? |
I'd still like to add this in 1.13. What is the dependency ordering between creating the repo & merging kubernetes/kubernetes#67791? I.e. which should be approved first? |
no specific order. they just both need to be done, if this is to be a staging repo. they key is approval from sig-arch on the name |
Naming the repo after the API group makes sense to me. API approvers @thockin approved and @liggitt didn't object on kubernetes/kubernetes#67791, so I'm going to approve this. Repos can also be renamed, so this doesn't have to be permanent. |
Repo is created. Ready for the publishing bot configs (https://github.com/kubernetes/publishing-bot) |
Also @tallclair, can you add the repo to sigs.yaml? |
I have created kubernetes/publishing-bot#135 for the publishing-bot so that all processes related to creating the repo are in place. But I've placed a hold on it because it shouldn't get merged until kubernetes/kubernetes#67791 gets merged in k/k. Also, for the record, kubernetes/test-infra#10194 is the PR updating branch-protection for https://github.com/kubernetes/node-api (thanks @cblecker for taking care of it!) |
kubernetes/kubernetes#67791 finally merged! 🎉 Aside from kubernetes/publishing-bot#135, is there anything else that needs to be done here, or should I close this issue? |
Cancelled the hold on that. The repo should get populated once the bot is redeployed.
I think the only thing remaining is add the new repo to |
Just realized https://github.com/kubernetes/node-api does not have a repo description. |
New Repo, or migrate existing
new repository
Requested name for new repository
node-api
Which Organization should it reside
kubernetes
Who should be provided access to this repository
@tallclair
@dchen1107
@derekwaynecarr
Approvals
Presented to sig-architecture, agreed to make the new API a CRD
https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md
Based on discussion of CRDs in core components, the new API should be a separate (staging) repo:
https://groups.google.com/forum/#!msg/kubernetes-sig-storage-wg-csi/x5CchIP9qiI/00Trm4g1CwAJ
/cc @thockin
Additional context for request
Will provide the node.k8s.io API group (& generated client) for https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md
The text was updated successfully, but these errors were encountered: