Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hyperkube references #2018

Merged
merged 1 commit into from
May 12, 2021
Merged

Remove hyperkube references #2018

merged 1 commit into from
May 12, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup deprecation

What this PR does / why we need it:

The next v1.18 release (v1.18.19) on 5/7/21 will bring v1.18 to End of Life: kubernetes/sig-release#1532
With that, we'll need to remove any remaining references to hyperkube.

Tracking issue: #2017

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove hyperkube references

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. needs-priority labels Apr 25, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2021
@justaugustus justaugustus mentioned this pull request Apr 25, 2021
Closed
6 tasks
@justaugustus
Copy link
Member Author

/hold until v1.18 and hyperkube is EOL (on 5/12/21)
cc: @kubernetes/release-engineering

/override pull-release-image-debian-hyperkube-base
ref: kubernetes/test-infra#21941

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Overrode contexts on behalf of justaugustus: pull-release-image-debian-hyperkube-base

In response to this:

/hold until v1.18 and hyperkube is EOL (on 5/12/21)
cc: @kubernetes/release-engineering

/override pull-release-image-debian-hyperkube-base
ref: kubernetes/test-infra#21941

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus mentioned this pull request Apr 25, 2021
Merged
@justaugustus
Copy link
Member Author

The remaining hyperkube references are removed in #2019.

mkumatag
mkumatag approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2021
@justaugustus justaugustus mentioned this pull request May 9, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2021
@justaugustus
Copy link
Member Author

It's been real, hyperkube!
/hold cancel
ref: https://groups.google.com/u/1/g/kubernetes-dev/c/c9mDzTsHnxM

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2021
@justaugustus
Copy link
Member Author

(Rebasing...)

@justaugustus
Remove hyperkube references
4fba468 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 12, 2021
@justaugustus
Copy link
Member Author

/override pull-release-image-debian-hyperkube-base
(This job is in the midst of being removed in kubernetes/test-infra#21941.)

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Overrode contexts on behalf of justaugustus: pull-release-image-debian-hyperkube-base

In response to this:

/override pull-release-image-debian-hyperkube-base
(This job is in the midst of being removed in kubernetes/test-infra#21941.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hasheddan
hasheddan approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2021
@puerco
Copy link
Member

puerco commented May 12, 2021

/lgtm
THanks!!!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 06cdec8 into kubernetes:master May 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@hasheddan hasheddan hasheddan approved these changes

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@puerco puerco

@mkumatag mkumatag

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @k8s-ci-robot @puerco @mkumatag @hasheddan