Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setcap: Build buster-v2.0.0 image #1992

Merged
merged 2 commits into from
May 9, 2021
Merged

setcap: Build buster-v2.0.0 image #1992

merged 2 commits into from
May 9, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Apr 9, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Continuation of #1991 / #1983

  • setcap: Build buster-v2.0.0 image

    Uses debian-base:buster-v1.6.0.

    Note: the image major version is arbitrarily bumped here to dissuade any
    inferences that it must match the debian-base image tag

Signed-off-by: Stephen Augustus [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

/hold for setcap bump
This also adds a missing entry for dependencies.yaml.
(ref: #1684)

Does this PR introduce a user-facing change?

- setcap: Build buster-v2.0.0 image

  Uses debian-base:buster-v1.6.0.

  Note: the image major version is arbitrarily bumped here to dissuade any
  inferences that it must match the debian-base image tag

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 9, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 9, 2021
@justaugustus justaugustus changed the title [WIP] debian-hyperkube-base: Build buster-v1.5.0 image Build new setcap and debian-hyperbase-base images Apr 9, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2021
@pacoxu
Copy link
Member

pacoxu commented Apr 23, 2021

/retest

#6 27.93 Unpacking libcap2:s390x (1:2.25-2) ...
#6 28.26 Error while loading /usr/sbin/rm: No such file or directory

test failed with k8s.gcr.io/build-image/debian-base-s390x:buster-v1.6.0

@BenTheElder
Copy link
Member

cross building for s390x flakes building images like this. a lot. it's known. cc @dims

@BenTheElder
Copy link
Member

IIRC there seems to be some issues with symlinks under s390x emulation. No idea why.

@dims
Copy link
Member

dims commented Apr 23, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 23, 2021 •
edited
Loading

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-image-debian-hyperkube-base 4aa1822 link /test pull-release-image-debian-hyperkube-base

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
setcap: Build buster-v2.0.0 image
e4e6e30 
Uses debian-base:buster-v1.6.0.

Note: the image major version is arbitrarily bumped here to dissuade any
inferences that it must match the debian-base image tag

Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus
setcap: Drop symlinks which already exist in debian-base
b1a0fe4 
Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus justaugustus changed the title Build new setcap and debian-hyperbase-base images setcap: Build buster-v2.0.0 image May 9, 2021
@justaugustus
Copy link
Member Author

/hold cancel
Dropped the hyperkube image build as it's scheduled for removal this week (ref: #2018)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2021
@justaugustus
Copy link
Member Author

/assign @hasheddan @saschagrunert @cpanato
cc: @kubernetes/release-engineering

cpanato
cpanato approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d04de43 into kubernetes:master May 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
8 participants
@justaugustus @pacoxu @BenTheElder @dims @k8s-ci-robot @cpanato @saschagrunert @hasheddan