Only versionize docs on new branches. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know this script well enough. Can we make a test github repo (or just script that sets up a test git clone) and test this to see what it does? Ideally, test it continually? |
|
@lavalamp yes, that's on the (in process) roadmap to get this running/mocked continuously (and tested). |
|
ref #7 |
| # versionize docs | ||
| if [[ "$PARENT_BRANCH" == master ]]; then | ||
| # versionize docs on new branches (from master) only | ||
| if [[ "$PARENT_BRANCH" == master && "$label" != "alpha" ]]; then |
There was a problem hiding this comment.
I don't understand this, but can you just check if you're on the master branch? We should never run versionize docs on the master branch, I'm pretty sure.
There was a problem hiding this comment.
In this context, this condition is correct. "alpha" releases only occur on the master.
But for readability, I'll update to condition specifically on the current branch. Update coming..
Ref #27218 #27205
david-mcmahon
force-pushed
the
versionize
branch
from
0870549
to
0795c4c
Compare
|
PTAL |
lavalamp
added
the
lgtm
|
LGTM |
adam-stokes
pushed a commit
to adam-stokes/release
that referenced
this pull request
Oct 18, 2018
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 10, 2021
- Ports state of the repository from https://github.com/alenkacz/ci-signal-report at alenkacz/ci-signal-report@0ab843f - Provides attribution to original authors of the code in this commit in order of commit history - Fixes lint issues in code - Adds copyright header to report.go Commits picked from the above repository: 0ab843f Adding LICENSE file e13b901 Merge pull request #1 from leonardpahlke/update-packaging 21d9d0c update packageing d1c99b8 update structure cf4595d Merge pull request #11 from mkorbi/report-v2 fbf55fb add -short, make version optional, change order of output e1b0a29 Fix go version, rate limit and add version variabl (#10) eaab27f Merge branch 'master' of github.com:alenkacz/ci-signal-report 513789b 1.17 fixes d3b7b85 Group by issues from the same sig (#9) 37672b7 Fix generated urls (#7) c36df2b Try to set up CI 1ea4d5b Always pick resolved column with highest ID (#6) cfd6d63 A bit polishing on readme 710c6f7 Update README.md (#1) d5eb427 Add token help fe16eaa Merge branch 'master' of github.com:alenkacz/ci-signal-report b6071fe Add 1.16 jobs, sig names improvements 8b755a4 Overview d236bf2 Readme 7fcdea6 Initial implementation Co-authored-by: Alena Varkockova <[email protected]> Co-authored-by: Jim Angel <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Max Körbächer <[email protected]> Signed-off-by: Nabarun Pal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref kubernetes/kubernetes#27218 kubernetes/kubernetes#27205