Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scalability] Add extended probes timeout for containerd tests #17296

Merged
merged 1 commit into from
Apr 20, 2020
Merged

[Scalability] Add extended probes timeout for containerd tests #17296

merged 1 commit into from
Apr 20, 2020

Conversation

jprzychodzen
Copy link
Contributor

/sig scalability
/assign @mm4tt
Ref. kubernetes/perf-tests#1110

Add custom probes measurement timeout for sig-scalability containerd preset.

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 20, 2020
mm4tt
mm4tt reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml
@@ -185,6 +185,8 @@ presets:
- labels:
preset-e2e-scalability-containerd: "true"
env:
- name: CL2_PROBE_MEASUREMENTS_CHECK_PROBES_READY_TIMEOUT
value: "10m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that 10min will be enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull of image can timeout after 6 minutes and will try again, and current timeout is 5 minutes, becoming in total 11 minutes. We can lover this as some work is already done - all pods are scheduled, and almost all of them should already run.

Checking values from test, this can be as low as 7-8 minutes (time for DNS probes to be reported to Prometheus for 100 node experimental runs), but I do not want to go so low here. A little overhead seams reasonable.

Please unhold if this SG.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jprzychodzen, mm4tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Apr 20, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5f62df0 into kubernetes:master Apr 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

@jprzychodzen: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-scalability-presets.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml

In response to this:

/sig scalability
/assign @mm4tt
Ref. kubernetes/perf-tests#1110

Add custom probes measurement timeout for sig-scalability containerd preset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@jprzychodzen @k8s-ci-robot @mm4tt