Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scalability] Add extended probes timeout for containerd tests #17296

Merged
merged 1 commit into from
Apr 20, 2020
Merged

[Scalability] Add extended probes timeout for containerd tests #17296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ presets:
- labels:
preset-e2e-scalability-containerd: "true"
env:
- name: CL2_PROBE_MEASUREMENTS_CHECK_PROBES_READY_TIMEOUT
value: "10m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that 10min will be enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull of image can timeout after 6 minutes and will try again, and current timeout is 5 minutes, becoming in total 11 minutes. We can lover this as some work is already done - all pods are scheduled, and almost all of them should already run.

Checking values from test, this can be as low as 7-8 minutes (time for DNS probes to be reported to Prometheus for 100 node experimental runs), but I do not want to go so low here. A little overhead seams reasonable.

Please unhold if this SG.

- name: KUBE_CONTAINER_RUNTIME
value: "containerd"
- name: LOG_DUMP_SAVE_SERVICES
Expand Down