Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define other usage monitoring solutions and fix for issue #13831

Merged
merged 7 commits into from
Apr 19, 2019
Merged

Define other usage monitoring solutions and fix for issue #13831

merged 7 commits into from
Apr 19, 2019

Conversation

thecrudge
Copy link
Contributor

Define more resource usage monitoring solutions

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 15, 2019
@netlify
Copy link

netlify bot commented Apr 15, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ddb60ff

https://deploy-preview-13831--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2019
@thecrudge thecrudge changed the title Define more resource usage monitoring solutions Define other usage monitoring solutions and fix for issue Apr 16, 2019
@thecrudge thecrudge mentioned this pull request Apr 16, 2019
Closed
@thecrudge
Copy link
Contributor Author

/assign @bradtopol

@Bradamant3
Copy link
Contributor

Bradamant3 commented Apr 19, 2019 •
edited
Loading

@thecrudge thanks for your PR! Can you please take the fix for issue 13746 out of this PR, so that we can review content for one issue at a time? 13746 also needs additional triage, so if you could wait on a PR for it, that would also help. Thanks for understanding!

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2019
@Bradamant3
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2019
@Bradamant3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit e61a551 into kubernetes:master Apr 19, 2019
@thecrudge thecrudge mentioned this pull request Apr 26, 2019
Closed
6 tasks
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@thecrudge @nowjean
Define other usage monitoring solutions and fix for issue (kubernetes…
c09511c 
…#13831)

* Provides snippet for PLEG

* Define more resource usage monitoring solutions

* Clarification on create-cluster

* Revert "Clarification on create-cluster"

This reverts commit 42061be.

* copyedit
@sftim sftim mentioned this pull request Aug 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@bradtopol bradtopol

@Bradamant3 Bradamant3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thecrudge @Bradamant3 @k8s-ci-robot @bradtopol