Tweak glossary entry for Static Pod #15731
Conversation
k8s-ci-robot
added
cncf-cla: yes
sftim
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 62ff0f0 https://deploy-preview-15731--kubernetes-io-master-staging.netlify.com |
| @@ -10,5 +10,4 @@ aka: | |||
| tags: | |||
| - fundamental | |||
| --- | |||
| A {{< glossary_tooltip text="pod" term_id="pod" >}} managed directly by the kubelet | |||
| daemon on a specific node, without the API server observing it. | |||
| A Pod managed directly by the kubelet on a specific node, without the API server controlling it. | |||
There was a problem hiding this comment.
hi @sftim. Did you get a clean, local build?
The preview looks like the other, correct previews in the past -- the Mirror Pod and Static Pod entries are in the glossary. Should the full_link field point to the new location for static-pod?
Question:
What happened to the glossary entries for Mirror Pod and Static Pod on the current kubernetes.io site?
What happened to the static-pod page when moved from tasks/administer-cluster to tasks/configure-pod-container/static-pod.md? It is odd that the preview is okay, but the site is not.
There was a problem hiding this comment.
Netlify built the PR and the preview looks OK, so that's enough to convince me. I didn't try this locally.
Good spot about the full_link:, I'll fix that.
There was a problem hiding this comment.
Would you have time to try and build locally -- I am really curious about the build failure 😃
There was a problem hiding this comment.
make docker-serve starts fine locally for this branch, and for master
There was a problem hiding this comment.
👍 My local build is fine -- except for the mirror pod issue in the new static-pod file.
There was a problem hiding this comment.
the mirror pod issue in the new static-pod file.
What issue is that @kbhawkey ? (I'm mostly concentrating elsewhere, sorry)
There was a problem hiding this comment.
Hi! I did a bit of testing. Lines 13 and 14 seem fine in my local hugo build (docker or hugo server). The date in static-pod and mirror-pod seem to cause an error.
See #15752.
- fix date of entry - fix link to page - drop Hugo shortcodes
sftim
force-pushed
the
20190808_static_pod_glossary_tweak
branch
from
e682f1d
to
62ff0f0
Compare
|
The date was wrong too: e682f1d#diff-c5154bb7feb1eb1e27a9265dff2c1257R4 |
sftim
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
lgtm |
|
Superseded by #15752 |
Prompted by a comment on #13831, I wonder if this change will help the glossary entry come out right.
Using glossary tooltips in glossary entries seems both: