-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword static pod task page #14831
Reword static pod task page #14831
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 60ef3cc https://deploy-preview-14831--kubernetes-io-master-staging.netlify.com |
74b7380
to
f65eabc
Compare
/assign @tfogo (think all comments are now addressed) |
@sftim 👋 Thanks for this! Thanks also for adding the redirect. ✨ There's one piece from @steveperry-53's feedback still to be addressed:
I notice mixed use of "kubelet" and "the kubelet" throughout. I also prefer "the kubelet" and would ask that you standardize accordingly. Otherwise, please squash your commits when you're ready to merge. 🙇 |
- Shape this to be more of a Task page - Move static pod task to pod & container section
f65eabc
to
60ef3cc
Compare
Changed to “the kubelet” or similar throughout. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi. I am trying to track down a local build problem. Did the static-pod file get moved? I see the source file, but I am having trouble building this file. Is this the current location of file on k8s/website: https://kubernetes.io/docs/tasks/administer-cluster/static-pod/ |
Hmm, I'm not sure what has happened here. My guess is some GitHub shenanigans, but it could somehow be my error instead. I expected that https://kubernetes.io/docs/tasks/configure-pod-container/static-pod/ would work and that https://kubernetes.io/docs/tasks/administer-cluster/static-pod/ would redirect there. |
Hi @sftim. I am seeing a problem with building the file in configure-pod-container/static-pod.md-- cannot find the mirror-pod glossary entry. The mirror-pod glossary file is in the source, but I cannot find the term in the glossary on the current website. Perhaps my eyes are tired. What about the |
- Shape this to be more of a Task page - Move static pod task to pod & container section
Reword https://kubernetes.io/docs/tasks/administer-cluster/static-pod/ and move it to https://kubernetes.io/docs/tasks/configure-pod-container/static-pod/ (where, I think, it belongs)
Split into multiple commits to make it easier to see the rewording.