Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword static pod task page #14831

Merged

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jun 11, 2019

Reword https://kubernetes.io/docs/tasks/administer-cluster/static-pod/ and move it to https://kubernetes.io/docs/tasks/configure-pod-container/static-pod/ (where, I think, it belongs)

Split into multiple commits to make it easier to see the rewording.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 11, 2019
@netlify
Copy link

netlify bot commented Jun 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 60ef3cc

https://deploy-preview-14831--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Contributor Author

sftim commented Jun 17, 2019

@jsafrane @jimangel how does this look to you?

@sftim sftim force-pushed the 20190611_reword_task_static_pod branch 2 times, most recently from 74b7380 to f65eabc Compare June 20, 2019 17:30
@sftim
Copy link
Contributor Author

sftim commented Jun 27, 2019

/assign @tfogo

(think all comments are now addressed)

@zacharysarah
Copy link
Contributor

@sftim 👋 Thanks for this! Thanks also for adding the redirect. ✨ There's one piece from @steveperry-53's feedback still to be addressed:

General note: Choose a way of referring to the kubelet, and then be consistent throughout the whole topic. I prefer "the kubelet", but some people use "kubelet". I'd recommend against "Kubelet".

I notice mixed use of "kubelet" and "the kubelet" throughout. I also prefer "the kubelet" and would ask that you standardize accordingly.

Otherwise, please squash your commits when you're ready to merge. 🙇

- Shape this to be more of a Task page
- Move static pod task to pod & container section
@sftim sftim force-pushed the 20190611_reword_task_static_pod branch from f65eabc to 60ef3cc Compare August 6, 2019 23:12
@sftim
Copy link
Contributor Author

sftim commented Aug 6, 2019

Changed to “the kubelet” or similar throughout.

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit dd6f88d into kubernetes:master Aug 6, 2019
@sftim sftim deleted the 20190611_reword_task_static_pod branch August 6, 2019 23:41
@kbhawkey
Copy link
Contributor

kbhawkey commented Aug 7, 2019

Hi. I am trying to track down a local build problem. Did the static-pod file get moved? I see the source file, but I am having trouble building this file.
Page preview:
https://deploy-preview-14831--kubernetes-io-master-staging.netlify.com/docs/tasks/configure-pod-container/static-pod/

Is this the current location of file on k8s/website:
https://kubernetes.io/docs/tasks/configure-pod-container/static-pod/

https://kubernetes.io/docs/tasks/administer-cluster/static-pod/

@sftim
Copy link
Contributor Author

sftim commented Aug 8, 2019

Hmm, I'm not sure what has happened here. My guess is some GitHub shenanigans, but it could somehow be my error instead.

I expected that https://kubernetes.io/docs/tasks/configure-pod-container/static-pod/ would work and that https://kubernetes.io/docs/tasks/administer-cluster/static-pod/ would redirect there.

@kbhawkey
Copy link
Contributor

kbhawkey commented Aug 8, 2019

Hi @sftim. I am seeing a problem with building the file in configure-pod-container/static-pod.md-- cannot find the mirror-pod glossary entry. The mirror-pod glossary file is in the source, but I cannot find the term in the glossary on the current website. Perhaps my eyes are tired.
https://kubernetes.io/docs/reference/glossary?fundamental=true

What about the Static Pod entry:
https://deploy-preview-14831--kubernetes-io-master-staging.netlify.com/docs/reference/glossary

wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
- Shape this to be more of a Task page
- Move static pod task to pod & container section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants