Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate concepts/workloads/controllers/replicationcontroller in Korean #15044

Merged
merged 5 commits into from
Jun 27, 2019
Merged

Translate concepts/workloads/controllers/replicationcontroller in Korean #15044

merged 5 commits into from
Jun 27, 2019

Conversation

marcushyungseoklee
Copy link

@k8s-ci-robot
Copy link
Contributor

Welcome @marcushyungseoklee!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 21, 2019
@netlify
Copy link

netlify bot commented Jun 21, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8256092

https://deploy-preview-15044--kubernetes-io-master-staging.netlify.com

@gochist
Copy link
Member

gochist commented Jun 21, 2019

@marcushyungseoklee 감사합니다! 본 PR의 베이스 브랜치가 master로 되어있는데요, dev-1.15-ko.1으로 변경을 부탁드립니다.

image

@marcushyungseoklee
Copy link
Author

marcushyungseoklee commented Jun 21, 2019 •
edited
Loading

@gochist 감사합니다^^

PR베이스 브랜치가 master로 되어있다고 하셨는데 확인해보니
Default branch is already dev-1.15-ko.1 로
이미 설정해놓은것 같은데 setting 외에 다른곳에서 변경이 필요한지요?

@gochist 아 다시 변경했습니다. 감사합니다

@marcushyungseoklee marcushyungseoklee changed the base branch from master to dev-1.15-ko.1 June 21, 2019 05:02
@gochist
Copy link
Member

gochist commented Jun 21, 2019

/assign

gochist
gochist reviewed Jun 24, 2019
View reviewed changes
Copy link
Member

@gochist gochist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcushyungseoklee 감사합니다! 리뷰 의견 드립니다. 참고를 부탁드린 내용은 선택적으로 반영 바랍니다.

content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/workloads/controllers/replicationcontroller.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2019
@netlify
Copy link

netlify bot commented Jun 25, 2019 •
edited
Loading

Deploy preview for k8s-dev-ko ready!

Built with commit 901eb90

https://deploy-preview-15044--k8s-dev-ko.netlify.com

@marcushyungseoklee
Copy link
Author

@gochist 꼼꼼한 리뷰 정말 감사드립니다.

@gochist
Copy link
Member

gochist commented Jun 25, 2019

@marcushyungseoklee 감사합니다! 커밋 중 다음 파일의 변경이 포함되어 있습니다. 의도한 변경이 아니라면 변경 내역에서 제외해주시고, 가능하면 단일 커밋으로 squash 부탁드립니다.

content/ko/docs/setup/production-environment/_index.md
content/ko/docs/setup/production-environment/container-runtimes.md
content/ko/docs/setup/production-environment/on-premises-vm/_index.md
content/ko/docs/setup/production-environment/on-premises-vm/cloudstack.md
content/ko/docs/setup/production-environment/on-premises-vm/dcos.md
content/ko/docs/setup/production-environment/on-premises-vm/ovirt.md
content/ko/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md
content/ko/docs/setup/production-environment/turnkey/_index.md
content/ko/docs/setup/production-environment/turnkey/alibaba-cloud.md
content/ko/docs/setup/production-environment/turnkey/aws.md
content/ko/docs/setup/production-environment/turnkey/azure.md
content/ko/docs/setup/production-environment/turnkey/clc.md
content/ko/docs/setup/production-environment/turnkey/gce.md
content/ko/docs/setup/production-environment/turnkey/icp.md
content/ko/docs/setup/production-environment/turnkey/stackpoint.md
content/ko/docs/setup/production-environment/windows/_index.md
content/ko/docs/setup/production-environment/windows/flannel-master-kubeclt-get-pods.png
content/ko/docs/setup/production-environment/windows/flannel-master-kubectl-get-ds.png
content/ko/docs/setup/production-environment/windows/intro-windows-in-kubernetes.md
content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md
content/ko/docs/setup/production-environment/windows/user-guide-windows-nodes.md
content/ko/docs/setup/production-environment/windows/windows-docker-error.png

@marcushyungseoklee
Copy link
Author

@gochist

@marcushyungseoklee 감사합니다! 커밋 중 다음 파일의 변경이 포함되어 있습니다. 의도한 변경이 아니라면 변경 내역에서 제외해주시고, 가능하면 단일 커밋으로 squash 부탁드립니다.

content/ko/docs/setup/production-environment/_index.md
content/ko/docs/setup/production-environment/container-runtimes.md
content/ko/docs/setup/production-environment/on-premises-vm/_index.md
content/ko/docs/setup/production-environment/on-premises-vm/cloudstack.md
content/ko/docs/setup/production-environment/on-premises-vm/dcos.md
content/ko/docs/setup/production-environment/on-premises-vm/ovirt.md
content/ko/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md
content/ko/docs/setup/production-environment/turnkey/_index.md
content/ko/docs/setup/production-environment/turnkey/alibaba-cloud.md
content/ko/docs/setup/production-environment/turnkey/aws.md
content/ko/docs/setup/production-environment/turnkey/azure.md
content/ko/docs/setup/production-environment/turnkey/clc.md
content/ko/docs/setup/production-environment/turnkey/gce.md
content/ko/docs/setup/production-environment/turnkey/icp.md
content/ko/docs/setup/production-environment/turnkey/stackpoint.md
content/ko/docs/setup/production-environment/windows/_index.md
content/ko/docs/setup/production-environment/windows/flannel-master-kubeclt-get-pods.png
content/ko/docs/setup/production-environment/windows/flannel-master-kubectl-get-ds.png
content/ko/docs/setup/production-environment/windows/intro-windows-in-kubernetes.md
content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md
content/ko/docs/setup/production-environment/windows/user-guide-windows-nodes.md
content/ko/docs/setup/production-environment/windows/windows-docker-error.png

@gochist 다른 이슈인 #14652 를 로컬 레포에서 작업하다가 들어간것 같습니다.
변경내역에서 제외하도록 하겠습니다.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 25, 2019
@gochist
Copy link
Member

gochist commented Jun 26, 2019

@marcushyungseoklee 감사합니다!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2019
@gochist
Copy link
Member

gochist commented Jun 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 976bc8c into kubernetes:dev-1.15-ko.1 Jun 27, 2019
@marcushyungseoklee marcushyungseoklee mentioned this pull request Jun 28, 2019
Closed
gochist added a commit that referenced this pull request Jul 9, 2019
@marcushyungseoklee @seokho-son
@lapee79 @yoonian @gochist
First Korean l10n work for release-1.15
c78b799 
* Translate concepts/workloads/controllers/replicationcontroller in Korean (#15044)
* ko: Update outdated 1.14-ko.4 branch (#15099)
* Translate tasks/access-application-cluster/configure-access-multiple-clusters in Korean (#15121)
* Translate standardized glossary items in Tag Network into Korean (#15278)
* ko: Keep up with upstream - renamed files (#15030)

Co-Authored-By: Seokho <[email protected]>
Co-Authored-By: lapee79 <[email protected]>
Co-Authored-By: Yoon <[email protected]>
Co-Authored-By: June Yi <[email protected]>
@gochist gochist mentioned this pull request Jul 9, 2019
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jul 10, 2019
@gochist @seokho-son
@lapee79 @yoonian @k8s-ci-robot
First Korean l10n work for release-1.15 (#15356)
113008f 
* Translate concepts/workloads/controllers/replicationcontroller in Korean (#15044)
* ko: Update outdated 1.14-ko.4 branch (#15099)
* Translate tasks/access-application-cluster/configure-access-multiple-clusters in Korean (#15121)
* Translate standardized glossary items in Tag Network into Korean (#15278)
* ko: Keep up with upstream - renamed files (#15030)

Co-Authored-By: Seokho <[email protected]>
Co-Authored-By: lapee79 <[email protected]>
Co-Authored-By: Yoon <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gochist gochist gochist left review comments

@sftim sftim sftim left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

Assignees

@gochist gochist

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcushyungseoklee @k8s-ci-robot @gochist @sftim