Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Indonesian Translation for Cloud Controller Manager Concepts page #15335

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Add Indonesian Translation for Cloud Controller Manager Concepts page #15335

merged 3 commits into from
Jul 10, 2019

Conversation

phanama
Copy link
Contributor

@phanama phanama commented Jul 8, 2019 •
edited
Loading

This PR translates Cloud Controller Manager Concepts docs to Bahasa Indonesia for #15341
Requesting reviews @girikuncoro @irvifa

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2019
@phanama
Copy link
Contributor Author

phanama commented Jul 8, 2019

/assign @irvifa
/assign @girikuncoro

@netlify
Copy link

netlify bot commented Jul 8, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6bc040f

https://deploy-preview-15335--kubernetes-io-master-staging.netlify.com

@girikuncoro girikuncoro mentioned this pull request Jul 8, 2019
Closed
45 tasks
@phanama phanama changed the title Add Cloud Controller Manager concepts Indonesian translation Add Cloud Controller Manager Concepts Indonesian translation Jul 9, 2019
@phanama phanama changed the title Add Cloud Controller Manager Concepts Indonesian translation Add Indonesian Translation for Cloud Controller Manager Concepts page Jul 9, 2019
@girikuncoro
Copy link
Contributor

@phanama beautiful translation! there are some minor typos, but overall great job! can merge after the typos have been addressed

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2019
@girikuncoro
Copy link
Contributor

Thanks for your contribution!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 60c570d into kubernetes:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girikuncoro girikuncoro girikuncoro requested changes

@irvifa irvifa Awaiting requested review from irvifa

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phanama @girikuncoro @k8s-ci-robot @irvifa