Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak glossary entry for Static Pod #15731

Closed
wants to merge 1 commit into from
Closed

Tweak glossary entry for Static Pod #15731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions content/en/docs/reference/glossary/static-pod.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
---
title: Static Pod
id: static-pod
date: 2091-02-12
full_link: /docs/tasks/administer-cluster/static-pod/
date: 2019-02-12
full_link: /docs/tasks/configure-pod-container/static-pod/
short_description: >
A pod managed directly by kubelet daemon on a specific node

aka:
tags:
- fundamental
---
A {{< glossary_tooltip text="pod" term_id="pod" >}} managed directly by the kubelet
daemon on a specific node, without the API server observing it.
A Pod managed directly by the kubelet on a specific node, without the API server controlling it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sftim. Did you get a clean, local build?
The preview looks like the other, correct previews in the past -- the Mirror Pod and Static Pod entries are in the glossary. Should the full_link field point to the new location for static-pod?
Question:
What happened to the glossary entries for Mirror Pod and Static Pod on the current kubernetes.io site?
What happened to the static-pod page when moved from tasks/administer-cluster to tasks/configure-pod-container/static-pod.md? It is odd that the preview is okay, but the site is not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlify built the PR and the preview looks OK, so that's enough to convince me. I didn't try this locally.

Good spot about the full_link:, I'll fix that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you have time to try and build locally -- I am really curious about the build failure 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make docker-serve starts fine locally for this branch, and for master

Copy link
Contributor

@kbhawkey kbhawkey Aug 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 My local build is fine -- except for the mirror pod issue in the new static-pod file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mirror pod issue in the new static-pod file.
What issue is that @kbhawkey ? (I'm mostly concentrating elsewhere, sorry)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I did a bit of testing. Lines 13 and 14 seem fine in my local hugo build (docker or hugo server). The date in static-pod and mirror-pod seem to cause an error.
See #15752.