Add YouTube social button in header and footer #16838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 0b0907a https://deploy-preview-16838--kubernetes-io-master-staging.netlify.com |
hvaara
force-pushed
the
social-youtube
branch
from
383f1fc
to
8a2d00e
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sftim
approved these changes
Oct 13, 2019
|
Thanks for the review @sftim! |
hvaara
force-pushed
the
social-youtube
branch
from
8a2d00e
to
b4c0285
Compare
k8s-ci-robot
removed
the
lgtm
|
Rebased on master, fixed merge conflict |
|
Thanks a lot for reviewing @kbhawkey! @Bradamant3 Friendly ping 😃 Do you have time to take a look? |
|
@zacharysarah do you think it's a good idea for me to continue working on this? I'd be happy to update again so it reflects the changes merged in #17325 |
|
@hvaara It sounds like a cool improvement, so go for it! |
|
@hvaara 👋 Please feel free to /close |
|
@zacharysarah: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @zacharysarah 👋 I am currently working on this /reopen |
|
@hvaara: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
hvaara
force-pushed
the
social-youtube
branch
from
b4c0285
to
0b0907a
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@zacharysarah Just pushed my changes. PTAL when you have time |
|
/assign @Rajakavitha1 |
|
@hvaara Thanks for this. ✨ /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
zacharysarah
pushed a commit
to zacharysarah/website
that referenced
this pull request
Dec 5, 2019
zacharysarah
pushed a commit
to zacharysarah/website
that referenced
this pull request
Dec 5, 2019
zacharysarah
pushed a commit
to zacharysarah/website
that referenced
this pull request
Dec 5, 2019
gochist
added a commit
to gochist/website
that referenced
this pull request
Dec 5, 2019
* Fix a command in kubectl cheatsheet (kubernetes#17888) * Remove dead links to old getting started guides (kubernetes#17889) * Change PowerShell example to use the -Raw flag (kubernetes#17645) * Spelling correction (kubernetes#17895) * fix some broken links (kubernetes#17897) * update exmaple for job (kubernetes#17903) * Deleted duplicate sentence and corrected typo (kubernetes#17902) * Corrected the typo of 'chck' with 'check' * Removed the duplicate sentence * Fix a dead link (kubernetes#17900) * fix 404 urls in kustomization.md (kubernetes#17793) * Update kustomization.md fix 404 urls in kustomization.md * Update content/en/docs/tasks/manage-kubernetes-objects/kustomization.md Co-Authored-By: Tim Bannister <[email protected]> * update kustomization.md to be more stable * Fix broken link to AWS provider settings source (kubernetes#17899) * update style guide for styling component names (kubernetes#17588) * update style guide for styling component names - Attempt to outline style conventions for components and component tools - Interested in comments and feedback * update style examples * style edits - removed code style for components not cmd tools - added style suggestion for namespaces - cleaned up a few stray spaces * fix output example in automated-tasks-with-cron-jobs.md (kubernetes#17906) * Update an out-of-date link (kubernetes#17907) Signed-off-by: umiblue <[email protected]> * en-fr: Append Note To Alternative Linux Install (kubernetes#17827) * Blog post: Gardener Project Update (kubernetes#17516) * Add Gardener Project Update blog post * Update and rename 2019-11-10-gardener-project-update.md to 2019-11-27-gardener-project-update.md * Update and rename 2019-11-27-gardener-project-update.md to 2019-12-02-gardener-project-update.md * Update KubeCon buttons for Shanghai (kubernetes#17916) * fix path not consistent (kubernetes#17923) * updated 3 logos on case studies page (kubernetes#17628) * Update kube-scheduler.md (kubernetes#17283) Fix grammar typo * Add missing `systemctl` step for running `cri-o` (kubernetes#17926) After installing `cri-o`, we must run `systemctl daemon-reload` before trying to run `systemctl start crio`. Otherwise, `systemd` doesn't know about the crio configuration. Similar instructions already exist for installing docker - this diff adds these instructions for crio. * add cidr to glossary (kubernetes#17550) * add CIDR * modify cidr definition * Update content/en/docs/reference/glossary/cidr.md Co-Authored-By: Chris <[email protected]> * Update content/en/docs/reference/glossary/cidr.md Co-Authored-By: Chris <[email protected]> * specify components requiring feature gate (kubernetes#17922) * specify components requiring feature gate currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to. * specify components requiring feature gate * Fixed hot reload panic of local hugo issue. (kubernetes#17894) * fix-up 404 urls (kubernetes#17936) * fix-up 404 urls * Revert "fix-up 404 urls" This reverts commit 4515c4d. * fix-ip 404 urls * fix-up 404 urls * Update guaranteed-scheduling-critical-addon-pods.md (kubernetes#17151) * Update guaranteed-scheduling-critical-addon-pods.md cleanup old stuff again * Update content/en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods.md Co-Authored-By: Tim Bannister <[email protected]> * Update guaranteed-scheduling-critical-addon-pods.md remove whitespace * correct diagram label (kubernetes#17942) * fix-up 404 urls (kubernetes#17941) * fix-up 404 urls * Revert "fix-up 404 urls" This reverts commit 4515c4d. * fix-ip 404 urls * fix-up 404 urls * fix-up 404 urls Revert "fix-up 404 urls" This reverts commit 4515c4d. fix-ip 404 urls fix-up 404 urls * fix-up 404 urls * Translate Minikube environment to French (kubernetes#17939) * Freshen the list of English content approvers for SIG Docs (kubernetes#17929) * Add YouTube social button in header and footer (kubernetes#16838) * Update the cluster create and disable commands (kubernetes#17947) * Initialize DNS Pod Service for ID Localization. (kubernetes#16707) Co-Authored-By: Giri Kuncoro <[email protected]> Co-Authored-By: Tim Bannister <[email protected]> * Add statefulsets for ID localization. (kubernetes#16700) * Initialize Common Label for ID Localization. (kubernetes#16706) * Add job running into completion in ID Localization. (kubernetes#16705) * Updated kubeone URL (kubernetes#17766)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a YouTube social button in the header and footer. The button links to https://www.youtube.com/kubernetescommunity
Closes #10226