Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify components requiring feature gate #17922

Merged
merged 2 commits into from
Dec 4, 2019
Merged

specify components requiring feature gate #17922

merged 2 commits into from
Dec 4, 2019

Conversation

boluisa
Copy link
Contributor

@boluisa boluisa commented Dec 3, 2019

currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17

For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh

For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@boluisa
specify components requiring feature gate
abedfa4 
currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 3, 2019
@boluisa
Copy link
Contributor Author

boluisa commented Dec 3, 2019

/assign @zacharysarah

@netlify
Copy link

netlify bot commented Dec 3, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a8f869e

https://deploy-preview-17922--kubernetes-io-master-staging.netlify.com

tengqm
tengqm reviewed Dec 3, 2019
View reviewed changes
content/en/docs/concepts/workloads/controllers/ttlafterfinished.md Outdated
@@ -16,7 +16,7 @@ objects that have finished execution. TTL controller only handles
now, and may be expanded to handle other resources that will finish execution,
such as Pods and custom resources.

Alpha Disclaimer: this feature is currently alpha, and can be enabled with
Alpha Disclaimer: this feature is currently alpha, and can be enabled with both kube-controller-manager and kube-scheduler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting finding. In your commit message, you said "currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager." Here you only mention the last two. So you see how difficult it is to remember exactly which component accepts which gate ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, the required flag here should be kube-apiserver and kube-controller-manager.

@tengqm
Copy link
Contributor

tengqm commented Dec 4, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 68194ab into kubernetes:master Dec 4, 2019
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
@boluisa
specify components requiring feature gate (kubernetes#17922)
677fe3e 
* specify components requiring feature gate 

currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.

* specify components requiring feature gate
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
@boluisa
specify components requiring feature gate (kubernetes#17922)
05dbc17 
* specify components requiring feature gate 

currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.

* specify components requiring feature gate
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
@boluisa
specify components requiring feature gate (kubernetes#17922)
5296f76 
* specify components requiring feature gate 

currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.

* specify components requiring feature gate
gochist added a commit to gochist/website that referenced this pull request Dec 5, 2019
@gochist
Reword commits that cause Prow warnings (#1)
ec5b784 
* Fix a command in kubectl cheatsheet (kubernetes#17888)

* Remove dead links to old getting started guides (kubernetes#17889)

* Change PowerShell example to use the -Raw flag (kubernetes#17645)

* Spelling correction (kubernetes#17895)

* fix some broken links (kubernetes#17897)

* update exmaple for job (kubernetes#17903)

* Deleted duplicate sentence and corrected typo (kubernetes#17902)

* Corrected the typo of 'chck' with 'check'

* Removed the duplicate sentence

* Fix a dead link (kubernetes#17900)

* fix 404 urls in kustomization.md (kubernetes#17793)

* Update kustomization.md

fix 404 urls in kustomization.md

* Update content/en/docs/tasks/manage-kubernetes-objects/kustomization.md

Co-Authored-By: Tim Bannister <[email protected]>

* update kustomization.md to be more stable

* Fix broken link to AWS provider settings source (kubernetes#17899)

* update style guide for styling component names (kubernetes#17588)

* update style guide for styling component names

- Attempt to outline style conventions for components
  and component tools
- Interested in comments and feedback

* update style examples

* style edits

- removed code style for components not cmd tools
- added style suggestion for namespaces
- cleaned up a few stray spaces

* fix output example in automated-tasks-with-cron-jobs.md (kubernetes#17906)

* Update an out-of-date link (kubernetes#17907)

Signed-off-by: umiblue <[email protected]>

* en-fr: Append Note To Alternative Linux Install (kubernetes#17827)

* Blog post: Gardener Project Update (kubernetes#17516)

* Add Gardener Project Update blog post

* Update and rename 2019-11-10-gardener-project-update.md to 2019-11-27-gardener-project-update.md

* Update and rename 2019-11-27-gardener-project-update.md to 2019-12-02-gardener-project-update.md

* Update KubeCon buttons for Shanghai (kubernetes#17916)

* fix path not consistent (kubernetes#17923)

* updated 3 logos on case studies page (kubernetes#17628)

* Update kube-scheduler.md (kubernetes#17283)

Fix grammar typo

* Add missing `systemctl` step for running `cri-o` (kubernetes#17926)

After installing `cri-o`, we must run `systemctl daemon-reload` before
trying to run `systemctl start crio`. Otherwise, `systemd` doesn't know
about the crio configuration.

Similar instructions already exist for installing docker - this diff
adds these instructions for crio.

* add cidr to glossary (kubernetes#17550)

* add CIDR

* modify cidr definition

* Update content/en/docs/reference/glossary/cidr.md

Co-Authored-By: Chris <[email protected]>

* Update content/en/docs/reference/glossary/cidr.md

Co-Authored-By: Chris <[email protected]>

* specify components requiring feature gate (kubernetes#17922)

* specify components requiring feature gate 

currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.

* specify components requiring feature gate

* Fixed hot reload panic of local hugo issue. (kubernetes#17894)

* fix-up 404 urls (kubernetes#17936)

* fix-up 404 urls

* Revert "fix-up 404 urls"

This reverts commit 4515c4d.

* fix-ip 404 urls

* fix-up 404 urls

* Update guaranteed-scheduling-critical-addon-pods.md (kubernetes#17151)

* Update guaranteed-scheduling-critical-addon-pods.md

cleanup old stuff again

* Update content/en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update guaranteed-scheduling-critical-addon-pods.md

remove whitespace

* correct diagram label (kubernetes#17942)

* fix-up 404 urls (kubernetes#17941)

* fix-up 404 urls

* Revert "fix-up 404 urls"

This reverts commit 4515c4d.

* fix-ip 404 urls

* fix-up 404 urls

* fix-up 404 urls

Revert "fix-up 404 urls"

This reverts commit 4515c4d.

fix-ip 404 urls

fix-up 404 urls

* fix-up 404 urls

* Translate Minikube environment to French (kubernetes#17939)

* Freshen the list of English content approvers for SIG Docs (kubernetes#17929)

* Add YouTube social button in header and footer (kubernetes#16838)

* Update the cluster create and disable commands (kubernetes#17947)

* Initialize DNS Pod Service for ID Localization. (kubernetes#16707)

Co-Authored-By: Giri Kuncoro <[email protected]>
Co-Authored-By: Tim Bannister <[email protected]>

* Add statefulsets for ID localization. (kubernetes#16700)

* Initialize Common Label for ID Localization. (kubernetes#16706)

* Add job running into completion in ID Localization. (kubernetes#16705)

* Updated kubeone URL (kubernetes#17766)
@boluisa boluisa mentioned this pull request Feb 3, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@sftim sftim Awaiting requested review from sftim

Assignees

@zacharysarah zacharysarah

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boluisa @tengqm @k8s-ci-robot @zacharysarah