-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect to correct 1.19 release blog date #23772
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 651e339 https://deploy-preview-23772--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/area blog
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -20,6 +20,7 @@ | |||
/vi/docs/ /vi/docs/home/ 301! | |||
/zh/docs/ /zh/docs/home/ 301! | |||
/blog/2018/03/kubernetes-1.10-stabilizing-storage-security-networking/ /blog/2018/03/26/kubernetes-1.10-stabilizing-storage-security-networking/ 301! | |||
/blog/2020/08/25/kubernetes-release-1.19-accentuate-the-paw-sitive/ /blog/2020/08/26/kubernetes-release-1.19-accentuate-the-paw-sitive/ 301! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine. Should the entry include 301
instead of 301!
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually know, I just copied the existing blog redirect on the previous line... no idea what the ! does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I recall, if the two entries exist (shadowing), the 301!
indicates to always prefer to redirect.
See, https://docs.netlify.com/routing/redirects/rewrites-proxies/#shadowing.
/lgtm |
Resolves a 404 in an uneditable link from the official project twitter account: https://twitter.com/kubernetesio/status/1298722760189833220