Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to correct 1.19 release blog date #23772

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Redirect to correct 1.19 release blog date #23772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions static/_redirects
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
/vi/docs/ /vi/docs/home/ 301!
/zh/docs/ /zh/docs/home/ 301!
/blog/2018/03/kubernetes-1.10-stabilizing-storage-security-networking/ /blog/2018/03/26/kubernetes-1.10-stabilizing-storage-security-networking/ 301!
/blog/2020/08/25/kubernetes-release-1.19-accentuate-the-paw-sitive/ /blog/2020/08/26/kubernetes-release-1.19-accentuate-the-paw-sitive/ 301!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Should the entry include 301 instead of 301!?

Copy link
Member Author

@liggitt liggitt Sep 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know, I just copied the existing blog redirect on the previous line... no idea what the ! does

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I recall, if the two entries exist (shadowing), the 301! indicates to always prefer to redirect.
See, https://docs.netlify.com/routing/redirects/rewrites-proxies/#shadowing.

/docs/admin/ /docs/concepts/cluster-administration/ 301
/docs/admin/add-ons/ /docs/concepts/cluster-administration/addons/ 301
/docs/admin/addons/ /docs/concepts/cluster-administration/addons/ 301
Expand Down