Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add placeholder docs for disabling node ports for Service Type=LB #24928

Closed
wants to merge 115 commits into from
Closed

[WIP] add placeholder docs for disabling node ports for Service Type=LB #24928

wants to merge 115 commits into from

Conversation

andrewsykim
Copy link
Member

Signed-off-by: Andrew Sy Kim [email protected]

Placeholder docs for KEP kubernetes/enhancements#1864

Documents that node ports can now be optionally disabled for Service Type=LoadBalancer.

cc @uablrek

savitharaghunathan and others added 30 commits August 26, 2020 17:25
Update config.toml to prepare 1.20 branch for the release
Merge master into dev-1.20 to keep in sync
Merge master into dev-1.20 to keep in sync
Promote startupProbe to GA in 1.20
Update docs for ServiceAccountIssuerDiscovery beta
Merge master into dev-1.20 to keep in sync
Updating doc for setHostnameAsFQDN feature to beta in v1.20
add documentation for system:monitoring rbac policy
Merge master into dev-1.20 to keep in sync
robscott and others added 9 commits November 20, 2020 16:58
Updating Service AppProtocol to GA
Updating EndpointSlice docs for 1.20
Update GC cross-namespace note
Misc updates to intro-windows-in-kubernetes.md
Add section on Built-in Defaulting
In 1.20 an optional metrics endpoint is added to the scheduler that
allows administrators to see the requested pod resources and the
imposed pod limits as metrics to better understand the capacity and
usage of the system under the pod model. Describe how these metrics
can be seen under cluster-administration.
docs: Scheduler resource tracking metrics
@annajung
Copy link
Contributor

Exception requested/granted. PR will be ready for review by EOD Wednesday the 25th

serathius and others added 3 commits November 23, 2020 23:49
* Document log sanitization feature

* Fill in log sanitization documentation

* Update content/en/docs/concepts/cluster-administration/system-logs.md

Co-authored-by: Marek Siarkowicz <[email protected]>

Co-authored-by: Rob Franken <[email protected]>
Co-authored-by: Rob Franken <[email protected]>
Follow up to PR #24845, following the remarks kbhawkey had
Small wording update on Log sanitization docs
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 607 to 618
#### Disabling Node Ports

TODO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also document that a LoadBalancer service comes, by default, with a NodePort.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will add some words for that

k-wiatrzyk and others added 2 commits November 24, 2020 14:10
Update Topology Manager documentation to include the scope feature
@andrewsykim
Copy link
Member Author

Do we also want to revise https://kubernetes.io/docs/tutorials/services/source-ip/?

I don't think so since we haven't changed any defaults around node ports so everything there still seems accurate.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2020
@k8s-ci-robot
Copy link
Contributor

@andrewsykim: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zparnold after the PR has been reviewed.
You can assign the PR to them by writing /assign @zparnold in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewsykim
Copy link
Member Author

Closing in favor of #25228

@andrewsykim
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@andrewsykim: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.