Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content/es/docs/tasks/tools #25481

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Update content/es/docs/tasks/tools #25481

merged 1 commit into from
Dec 18, 2020

Conversation

leeyspaul
Copy link
Contributor

@leeyspaul leeyspaul commented Dec 8, 2020 •
edited
Loading

Spanish translation of content/es/docs/tasks/tools

Parent: #13948

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2020
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 8, 2020
@netlify
Copy link

netlify bot commented Dec 8, 2020 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 145710b

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fdabd5a6a105a00073007cf

😎 Browse the preview: https://deploy-preview-25481--kubernetes-io-master-staging.netlify.app

@leeyspaul
Copy link
Contributor Author

ptal @raelga I closed the last PR as it got really messy and started a new here. I'm seeing a block due to the newest release but please let me know if there's anything I should fix in the meantime!

sftim
sftim requested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come content/es/docs/tasks/tools/_index.md is in English? That doesn't look right.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2020
@leeyspaul
Copy link
Contributor Author

Yeah, sorry about that. Difficulty focusing yesterday haha, thanks for catching it! Just pushed up the Spanish files now.

@raelga raelga self-assigned this Dec 10, 2020
raelga
raelga requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leeyspaul thanks for updating the tools section!

The review addresses some weird wording (some parts looked like generated by an automated translation) and some typos.

Feel free to ping me on slack if you have any question regarding the review!

content/es/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/install-kubectl.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/install-kubectl.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/install-kubectl.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/install-kubectl.md Outdated Show resolved Hide resolved
content/es/docs/tasks/tools/install-kubectl.md Outdated Show resolved Hide resolved
@leeyspaul
Copy link
Contributor Author

Thank you for those. Spanish is a bit rusty haha. I appreciate the fixes and feedback! Please let me know if there is anything else. @raelga

@raelga
Copy link
Member

raelga commented Dec 15, 2020

Thanks @leeyspaul! :D

Can you rebase your branch into a single commit?

@raelga
Copy link
Member

raelga commented Dec 15, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 15, 2020
@leeyspaul leeyspaul force-pushed the update-content-es-docs-tasks-tools- branch 2 times, most recently from 579b8b8 to 74be5b9 Compare December 16, 2020 01:53
@leeyspaul
Copy link
Contributor Author

Ok, I rebased into a single commit. Sorry it's a bit messy haha. Please let me know if there's anything else I need to fix!

raelga
raelga requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leeyspaul, last change request, I promise!

content/es/docs/tasks/tools/install-kubectl.md Show resolved Hide resolved
content/es/docs/tasks/tools/install-kubectl.md Show resolved Hide resolved
@leeyspaul @raelga
spanish translation
145710b 
spanish translation

spanish translation install minikube

fix filename to kubectl

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/install-kubectl.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/install-kubectl.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/install-kubectl.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/install-kubectl.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/install-kubectl.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/install-kubectl.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/_index.md

Co-authored-by: Rael Garcia <[email protected]>

Update content/es/docs/tasks/tools/install-kubectl.md

Co-authored-by: Rael Garcia <[email protected]>

Apply suggestions from code review

Co-authored-by: Rael Garcia <[email protected]>

Apply suggestions from code review

Co-authored-by: Rael Garcia <[email protected]>
@leeyspaul leeyspaul force-pushed the update-content-es-docs-tasks-tools- branch from 5476768 to 145710b Compare December 17, 2020 02:07
@leeyspaul
Copy link
Contributor Author

Do let me know if there is anything else :]

@raelga
Copy link
Member

raelga commented Dec 18, 2020

Thanks @leeyspaul, the tab "glitch" is still there, but the raw code looks good (the same as the properly rendered english version). Let's merge it and see if it works, is only aesthetics and the content looks good!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 126df5010db65a50aede8b8e8f17fb6a95a0503e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 401665f into kubernetes:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga requested changes

@sftim sftim sftim requested changes

@alexbrand alexbrand Awaiting requested review from alexbrand

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@raelga raelga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leeyspaul @raelga @k8s-ci-robot @sftim