[en] Fix label selector in "kubectl for Docker Users" #27414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit ee1361d https://deploy-preview-27414--kubernetes-io-master-staging.netlify.app |
This was referenced Apr 5, 2021
Aut0R3V
reviewed
Apr 6, 2021
| @@ -279,7 +279,7 @@ deployment "nginx-app" deleted | |||
| ``` | |||
There was a problem hiding this comment.
Well I guess it passes most of the tests, maybe it can be approved.
Aut0R3V
approved these changes
Apr 6, 2021
|
/assign @tengqm |
joostas
force-pushed
the
docker-cli-to-kubectl-en
branch
2 times, most recently
from
9f93e5f
to
74d6495
Compare
joostas
force-pushed
the
docker-cli-to-kubectl-en
branch
2 times, most recently
from
2fed218
to
1aaa482
Compare
joostas
force-pushed
the
docker-cli-to-kubectl-en
branch
from
1aaa482
to
cfd9ef6
Compare
|
LGTM label has been added. Git tree hash: fa3105266e7903c2fbd1e2ef7013c6846ca5470a
|
k8s-ci-robot
added
the
lgtm
Before ```sh kubectl get po -l run=nginx-app No resources found in default namespace. ``` Because: ```sh kubectl get po --show-labels NAME READY STATUS RESTARTS AGE LABELS nginx-app-58cfd4c468-jx6qp 1/1 Running 0 17m app=nginx-app,pod-template-hash=58cfd4c468 ``` After: ```sh kubectl get po -l app=nginx-app NAME READY STATUS RESTARTS AGE nginx-app-58cfd4c468-jx6qp 1/1 Running 0 18m ```
joostas
force-pushed
the
docker-cli-to-kubectl-en
branch
from
cfd9ef6
to
ee1361d
Compare
k8s-ci-robot
removed
the
lgtm
|
/approve |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e273e9330ea32c0b69aa0a6298c508cd42bed834
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Aut0R3V, dims, irvifa, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
kubectl get po -l run=nginx-app No resources found in default namespace.Because:
After: