Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Fix label selector in "kubectl for Docker Users" #27417

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

joostas
Copy link
Contributor

@joostas joostas commented Apr 5, 2021

Ref. #27414

Before:

kubectl get po -l run=nginx-app
No resources found in default namespace.

Because:

kubectl get po --show-labels
NAME                         READY   STATUS    RESTARTS   AGE   LABELS
nginx-app-58cfd4c468-jx6qp   1/1     Running   0          17m   app=nginx-app,pod-template-hash=58cfd4c468

After:

kubectl get po -l app=nginx-app
NAME                         READY   STATUS    RESTARTS   AGE
nginx-app-58cfd4c468-jx6qp   1/1     Running   0          18m

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2021
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2021
@netlify
Copy link

netlify bot commented Apr 5, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2c3ece8

https://deploy-preview-27417--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Apr 7, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7843e960ffdb6a888b5db03e5e3928cd3d0bf48

@joostas
Copy link
Contributor Author

joostas commented Apr 10, 2021

/assign @chenrui333

@tengqm
Copy link
Contributor

tengqm commented Apr 12, 2021

@joostas You may want to rebase this on to "master" and see if the merge is still blocked.

Before:
```sh
kubectl get po -l run=nginx-app
No resources found in default namespace.
```
Because:
```sh
kubectl get po --show-labels
NAME                         READY   STATUS    RESTARTS   AGE   LABELS
nginx-app-58cfd4c468-jx6qp   1/1     Running   0          17m   app=nginx-app,pod-template-hash=58cfd4c468
```
After:
```sh
kubectl get po -l app=nginx-app
NAME                         READY   STATUS    RESTARTS   AGE
nginx-app-58cfd4c468-jx6qp   1/1     Running   0          18m
```
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@tengqm
Copy link
Contributor

tengqm commented Apr 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9daaf97565929aef1ffb384eda9fe887c04f4105

@k8s-ci-robot k8s-ci-robot merged commit 732d118 into kubernetes:master Apr 12, 2021
@joostas
Copy link
Contributor Author

joostas commented Apr 12, 2021

@joostas You may want to rebase this on to "master" and see if the merge is still blocked.

Thanks for the guidance @tengqm!

@joostas joostas deleted the docker-cli-kubectl-zh branch April 12, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants