Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configuration related docs #102

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Update configuration related docs #102

merged 3 commits into from
Jul 21, 2022

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jul 20, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

Preview URL: https://multi-config.botkube-docs.pages.dev/

Helm chart params will be updated once kubeshop/botkube#648 and #99 will be merged.

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Jul 20, 2022
@mszostok mszostok added this to the v0.13.0 milestone Jul 20, 2022
@mszostok mszostok mentioned this pull request Jul 20, 2022
Merged
@mszostok mszostok force-pushed the multi-config branch 2 times, most recently from 1c36cca to 7261429 Compare July 20, 2022 11:47
@pkosiec pkosiec self-assigned this Jul 20, 2022
pkosiec
pkosiec reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments 🙂

content/contribute/_index.md Show resolved Hide resolved
content/configuration/global.md Outdated Show resolved Hide resolved
content/configuration/communication/_index.md Outdated Show resolved Hide resolved
content/configuration/_index.md Outdated Show resolved Hide resolved
content/configuration/_index.md Outdated Show resolved Hide resolved
content/configuration/_index.md Outdated Show resolved Hide resolved
content/configuration/_index.md Outdated Show resolved Hide resolved
pkosiec
pkosiec approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address the comments before merge. Thanks!

content/configuration/helm-chart-parameters.md Outdated Show resolved Hide resolved
content/examples/_index.md Outdated Show resolved Hide resolved
@mszostok mszostok merged commit 90394aa into kubeshop:main Jul 21, 2022
@mszostok mszostok deleted the multi-config branch July 21, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees

@pkosiec pkosiec

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

The resource_config.yaml and comm_config.yaml are merged into one, and can be provided multiple times.
2 participants
@mszostok @pkosiec