Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The resource_config.yaml and comm_config.yaml are merged into one, and can be provided multiple times. #643

Closed
Tracked by #596
mszostok opened this issue Jul 13, 2022 · 0 comments · Fixed by #648 or kubeshop/botkube-docs#102
Assignees
Labels
enhancement New feature or request refactor Code refactoring. No functional changes
Milestone

Comments

@mszostok
Copy link
Contributor

mszostok commented Jul 13, 2022

Overview

The resource_config.yaml and comm_config.yaml are merged into one, and can be provided multiple times.
It’s up to the user how it will be split.

Acceptance Criteria

  • All configuration settings can be defined in a single file.
    • The file name is not hard-coded. User can pick any name they want.
  • Multiple files are merged together.
    • We should focus to merge the most top level properties. Complex, nested merging doesn't need to be supported.
  • User is able to override given settings via environment variable, e.g. BOTKUBE_COMMUNICATIONS_SLACK_TOKEN

Reason

The resource_config.yaml and comm_config.yaml grow in a way that they don't hold the logic that the hard-coded file name says. Additionally, user needs to ensure that the file are named in that way, and don't have option to split them into multiple files. Currently, it needs to be one YAML files that get bigger and bigger.

@mszostok mszostok added this to the v0.13.0 milestone Jul 13, 2022
@mszostok mszostok added enhancement New feature or request refactor Code refactoring. No functional changes breaking Contains breaking change labels Jul 13, 2022
@mszostok mszostok self-assigned this Jul 13, 2022
@mszostok mszostok removed the breaking Contains breaking change label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Code refactoring. No functional changes
Projects
None yet
1 participant