Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now we can support RBAC #254

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Now we can support RBAC #254

merged 4 commits into from
Aug 7, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • RBAC limitation is removed on CLI migrate

Testing

Related issue(s)

@huseyinbabal huseyinbabal requested review from PrasadG193 and a team as code owners August 3, 2023 09:52
@huseyinbabal huseyinbabal requested review from mszostok and removed request for a team August 3, 2023 09:52
@huseyinbabal huseyinbabal mentioned this pull request Aug 3, 2023
Merged
@mszostok
Copy link
Contributor

mszostok commented Aug 3, 2023

please run mage sync:cli and also describe limitation with extraObjects as mentioned here kubeshop/botkube#1171 (comment)

Thanks 🙇

@mszostok mszostok added the enhancement New feature or request label Aug 3, 2023
@mszostok mszostok added this to the v1.3.0 milestone Aug 3, 2023
@huseyinbabal
Copy link
Contributor Author

please run mage sync:cli and also describe limitation with extraObjects as mentioned here kubeshop/botkube#1171 (comment)

Thanks 🙇

Synced, and rephrased the limitations.

@huseyinbabal huseyinbabal merged commit 1863918 into kubeshop:main Aug 7, 2023
2 checks passed
@huseyinbabal huseyinbabal deleted the cli-rbac-support branch August 7, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Botkube
Status: Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @mszostok