Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC support added to CLI Migrate #1171

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • RBAC section is now shipped to Cloud on migrate command

Testing

  • Run cloud app locally
  • Deploy botkube in local k8s cluster
  • Go to cli folder cd cmd/cli
  • Build CLI go build -o bctl main.go
  • Login to local cloud ./bctl login --cloud-dashboard-url http://localhost:3000
  • Migrate deployment ./bctl migrate --cloud-api-url http://localhost:8080/graphql

Related issue(s)

Relates https://github.com/kubeshop/botkube-cloud/issues/99

@mszostok mszostok self-assigned this Aug 2, 2023
@mszostok mszostok added the enhancement New feature or request label Aug 2, 2023
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I spot some problems but we will address them in the follow-ups 👍

internal/ptr/ptr.go Outdated Show resolved Hide resolved
@mszostok
Copy link
Contributor

mszostok commented Aug 2, 2023

@huseyinbabal Please also update this document https://docs.botkube.io/cli/migrating-installation-to-botkube-cloud

also as agreed on Slack, please describe that the extraObjects are not migrated. So the helm upgrade that we perform simply removes all of them, so if user had cluster roles or bindings there, then they need to migrate them on their own to make sure that migrated plugin RBAC config will work properly.

@huseyinbabal huseyinbabal enabled auto-merge (squash) August 3, 2023 09:50
@huseyinbabal
Copy link
Contributor Author

@huseyinbabal Please also update this document https://docs.botkube.io/cli/migrating-installation-to-botkube-cloud

also as agreed on Slack, please describe that the extraObjects are not migrated. So the helm upgrade that we perform simply removes all of them, so if user had cluster roles or bindings there, then they need to migrate them on their own to make sure that migrated plugin RBAC config will work properly.

kubeshop/botkube-docs#254

@huseyinbabal huseyinbabal merged commit 593746a into kubeshop:main Aug 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants