Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fine-grained configuration per channels for the same bot (e.g. Slack) #596

Closed
13 tasks done
pkosiec opened this issue May 25, 2022 · 3 comments
Closed
13 tasks done
Assignees
Labels
enhancement New feature or request epic Describes a high-level epic(with subtasks)
Milestone

Comments

@pkosiec
Copy link
Member

pkosiec commented May 25, 2022

Overview

This issue is an epic and aggregates all the subtasks to finalize the complete feature.

Reason

There is a demand in community—5 open issues with a lot of reactions—to make the configuration more flexible in regards which notification should be collected and where to send.

Acceptance Criteria

To do

Related issues

This issue aggregates the feature requests from:

All the tasks above will be eventually closed and the tracking of the feature will be done here.

@pkosiec pkosiec added enhancement New feature or request needs-triage Relates to issues that should be refined labels May 25, 2022
@pkosiec pkosiec added this to the v0.13.0 milestone May 25, 2022
@mszostok mszostok self-assigned this Jun 6, 2022
@pkosiec pkosiec added the epic Describes a high-level epic(with subtasks) label Jun 9, 2022
@mszostok
Copy link
Contributor

mszostok commented Jun 14, 2022

Findings

The #250 is not strictly related to this issue, see my #250 (comment).

However, in the backlog I spot new related issues:

Additionally, almost 2 years ago, one of the contributor tried to solve this problem and submitted PR for that #291. Unfortunately, this pull request is too outdated and the work would need to be started from the ground.

Proposal

As a part of this task, I noticed that the configuration syntax has a few design issues. Because we need to extend that syntax, it would be good to also refactor it at the same time. Please take a look at:

@mszostok mszostok changed the title Ability to configure BotKube with multiple channels for the same bot (e.g. Slack) Support fine-grained configuration per channels for the same bot (e.g. Slack) Jun 27, 2022
mergify bot pushed a commit that referenced this issue Jul 1, 2022
…623

##### ISSUE TYPE
 - Docs Pull Request

##### SUMMARY

- Investigations:
  - [Add document that describes found issues with the current syntax for BotKube configuration.](https://github.com/mszostok/botkube/blob/add-cfg-proposal/docs/investigation/2022-06-15-cfg-syntax-issues.md)
  - Add document that describes how to solve multichannel support and configuration issues:
    - [with policies/presets/profiles concept](https://github.com/mszostok/botkube/blob/add-cfg-proposal/docs/proposal/2022-06-14-policies.md)
    - [via dedicated CustomResources (CR) instead of configuration files.](https://github.com/mszostok/botkube/blob/add-cfg-proposal/docs/proposal/2022-06-20-cfg-via-crds.md)

- Move the `design` docs into `docs/proposal`.
- Add readme and templates to `docs/{proposal,investigation}`

Related issues:
- #596
@mszostok mszostok removed the needs-triage Relates to issues that should be refined label Jul 6, 2022
@mszostok
Copy link
Contributor

mszostok commented Jul 20, 2022

@pkosiec
Copy link
Member Author

pkosiec commented Aug 25, 2022

Closing as all subtasks have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic Describes a high-level epic(with subtasks)
Projects
None yet
Development

No branches or pull requests

2 participants