Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure specific recommendations during BotKube installation/upgrade #684

Closed
5 tasks done
pkosiec opened this issue Aug 10, 2022 · 0 comments · Fixed by #696
Closed
5 tasks done
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pkosiec
Copy link
Member

pkosiec commented Aug 10, 2022

Overview

Implement ability to turn on/off recommendations according to the proposal: https://github.com/kubeshop/botkube/blob/main/docs/proposal/2022-06-14-configuration-bindings.md#new-syntax

        # Recommendations about the best practices
        recommendations:
          image:     # "Checks if 'latest' image tag is used for container image."
            enabled: true
          pod:       # "Checks if labels are missing in the pod specs."
            enabled: true
          ingress:   # "Checks if services and tls secrets used in ingress are available."
            enabled: true

Acceptance Criteria

  • Support recommendation configuration under source and enable/disable proper recommendations during BotKube startup
  • Ensure enabling/disabling filters in runtime via @BotKube command still works
  • Update documentation
  • Update merging strategy to "override" to be consistent with Executor.Kubectl.Commands.RestrictAccess
  • Create informers if recommendations are enabled, even if Ingress and Pod resources are not configured in the resources configuration (blocked by Support routing notifications to a given channel based on Kubernetes Sources #676)

Reason

See epic #596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant