Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support routing notifications to a given channel based on Kubernetes Sources #676

Closed
pkosiec opened this issue Aug 5, 2022 · 3 comments · Fixed by #691
Closed

Support routing notifications to a given channel based on Kubernetes Sources #676

pkosiec opened this issue Aug 5, 2022 · 3 comments · Fixed by #691
Assignees
@ezodude
Labels
enhancement New feature or request
Milestone
v0.13.0

Comments

@pkosiec
Copy link
Member

pkosiec commented Aug 5, 2022 •
edited by ezodude
Loading

Overview

User should be able to define different notification sources per a given channel based on the Kubernetes namespace. See the proposal section: https://github.com/kubeshop/botkube/blob/main/docs/proposal/2022-06-14-configuration-bindings.md#route-notifications-to-a-given-channel-based-on-the-kubernetes-namespace

Currently, the sources bindings introduced in new config are not supported:

botkube/helm/botkube/values.yaml

Lines 328 to 329 in 95918ec

sources:
- k8s-events

The scope of this task is to:

  • support source bindings in all communication platforms
  • support Kubernetes event namespace filtering by another property for kubernetes source (This has been de-scoped)

Acceptance Criteria

  • Add new namespace.include/exclude property in the sources.'group-name'.kubernetes according to the proposal (This has been de-scoped)
  • Ensure multiple source definitions are supported
  • Support source bindings per channel / index for all communication platforms (bots and sinks)
  • Update documentation on botkube-docs repo
  • Add required unit and E2E tests

Reason

See epic #596.
@pkosiec pkosiec added the enhancement New feature or request label Aug 5, 2022
@pkosiec pkosiec added this to the v0.13.0 milestone Aug 5, 2022
@pkosiec pkosiec changed the title Support kubectl namespaces and source bindings Support routing notifications to a given channel based on Kubernetes Namespace Aug 5, 2022
@pkosiec pkosiec mentioned this issue Aug 5, 2022
Closed
13 tasks
@ezodude ezodude self-assigned this Aug 8, 2022
@ezodude
Copy link
Contributor

ezodude commented Aug 8, 2022 •
edited
Loading

Now in code exploration/spike mode.

@ezodude ezodude changed the title Support routing notifications to a given channel based on Kubernetes Namespace Support routing notifications to a given channel based on Kubernetes Sources Aug 8, 2022
@pkosiec
Copy link
Member Author

pkosiec commented Aug 10, 2022 •
edited
Loading

BTW @ezodude regarding the comments

(This has been de-scoped)

I think there was a misunderstanding. I believe that's still a scope of this task, but this is definitely something to do in a follow-up PR (not in the first one) 🙂 And then we will have all parts together of the whole multi-workspace/multi-channel configuration epic.

This was referenced Aug 11, 2022
Merged
Merged
pkosiec added a commit that referenced this issue Aug 12, 2022
@pkosiec
Add ability to configure specific recommendations during BotKube inst…
2344f19 
…allation/upgrade (#687)

- Add ability to configure recommendations in granular way inside the config
- Nest `recommendations` under Kubernetes source (`sources.'alias'.kubernetes`)
- Post recommendations according to source configurations (full support will be introduced in #676)
- Move recommendations out of filters
- Add unit tests for all recommendations
- Improve recommendation messages
- Update E2E tests
- Fix receiving events on other namespaces
- Remove unused code
This was referenced Aug 16, 2022
Closed
Closed
@ezodude ezodude mentioned this issue Aug 16, 2022
Merged
8 tasks
@pkosiec pkosiec reopened this Aug 23, 2022
@ezodude ezodude mentioned this issue Aug 23, 2022
Closed
5 tasks
@pkosiec
Copy link
Member Author

pkosiec commented Aug 23, 2022

Ok, I see you extracted the namespaces functionality to a separate task. Closing it then 👍

@pkosiec pkosiec closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezodude ezodude

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

Support routing notifications to a given channel based on Kubernetes Sources ezodude/botkube
2 participants
@ezodude @pkosiec