Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0-rc1 bug fixes #1035

Merged
merged 3 commits into from
Apr 3, 2023
Merged

1.0.0-rc1 bug fixes #1035

merged 3 commits into from
Apr 3, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Heartbeat reporting fixed
  • Log formatting fixes
  • Plugin publish fix

Testing

Related issue(s)

@huseyinbabal huseyinbabal requested review from a team and PrasadG193 as code owners April 3, 2023 08:20
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/vulnerability-scan.yml:scan-repo. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

pkosiec
pkosiec approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huseyinbabal huseyinbabal merged commit 6b1cdd1 into kubeshop:release-1.0 Apr 3, 2023
@huseyinbabal huseyinbabal deleted the 1-0-0-rc1-bugfixes branch April 3, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @pkosiec