Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle K8s empty resource list for K8s 1.26+ #1194

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Handle K8s empty resource list for K8s 1.26+ #1194

merged 1 commit into from
Aug 18, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Aug 16, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Handle K8s empty resource list for K8s 1.26+

NOTE: It should be cherry picked for 1.3.1 too.

Testing

NOTE: I tried to follow the instruction from previous similar PR: #834
Even with older KEDA 2.9 couldn't reproduce that on K8s 1.27. Maybe that was fixed on Kubernetes side too? 🤔 Anyway, I added a unit test to cover this.

Install Botkube with the following overrides:

--set image.repository=kubeshop/pr/botkube \
--set image.tag=1194-PR \

Related issue(s)

Resolves #1173

@pkosiec pkosiec added the bug Something isn't working label Aug 16, 2023
@pkosiec pkosiec added this to the v1.4.0 milestone Aug 16, 2023
@pkosiec pkosiec marked this pull request as ready for review August 16, 2023 14:40
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners August 16, 2023 14:40
@pkosiec pkosiec requested a review from mszostok August 16, 2023 14:40
mszostok
mszostok approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkosiec pkosiec merged commit b34d85e into kubeshop:main Aug 18, 2023
13 checks passed
@pkosiec pkosiec deleted the fix-empty-res branch August 18, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Handling k8s empty resource list properly
2 participants
@pkosiec @mszostok