Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around empty K8s resources list which causes Botkube crash #834

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Work around empty K8s resources list which causes Botkube crash #834

merged 1 commit into from
Nov 3, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Nov 3, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Work around empty K8s resources list which causes Botkube crash

See the discussion under #829.

Testing

DO NOT checkout this PR (yet)

  1. Install KEDA (Helm chart).

  2. Run Botkube locally

    export BOTKUBE_SETTINGS_LOG_LEVEL=info
export BOTKUBE_SETTINGS_KUBECONFIG=$KUBECONFIG
export BOTKUBE_CONFIG_PATHS="$(pwd)/resource_config.yaml,$(pwd)/comm_config.yaml"
go run ./cmd/botkube/main.go

  3. See the crash error

  4. Check out to this PR with gh pr checkout 834

  5. Run Botkube locally once again

Related issue(s)

Resolves #829

@pkosiec pkosiec added the bug Something isn't working label Nov 3, 2022
@pkosiec pkosiec added this to the v0.15.0 milestone Nov 3, 2022
@pkosiec pkosiec changed the title Workaround empty K8s resources list which causes Botkube crash Work around empty K8s resources list which causes Botkube crash Nov 3, 2022
@pkosiec pkosiec modified the milestones: v0.15.0, v0.16.0 Nov 3, 2022
@pkosiec pkosiec force-pushed the empty-resource-list-workaround branch from 87b1a5e to fe5b393 Compare November 3, 2022 15:42
@pkosiec pkosiec marked this pull request as ready for review November 3, 2022 15:42
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners November 3, 2022 15:42
@pkosiec pkosiec mentioned this pull request Nov 3, 2022
Closed
josefkarasek
josefkarasek approved these changes Nov 3, 2022
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

huseyinbabal
huseyinbabal approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pkosiec pkosiec merged commit 8385843 into kubeshop:main Nov 3, 2022
@pkosiec pkosiec deleted the empty-resource-list-workaround branch November 3, 2022 16:15
@mszostok mszostok mentioned this pull request Jan 13, 2023
Closed
@pkosiec pkosiec mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Got empty response for: external.metrics.k8s.io/v1beta1
3 participants
@pkosiec @huseyinbabal @josefkarasek