Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configuration syntax proposal #626

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jun 27, 2022

ISSUE TYPE
  • Proposal Pull Request
SUMMARY

Add document that describes how to solve multichannel support and configuration issues with bindings concept.

It is based on the investigation from #623

Related issue: #596

@mszostok mszostok added documentation Documetation is missing or incorrect community labels Jun 27, 2022
@mszostok mszostok added this to the v0.13.0 milestone Jun 27, 2022
@mszostok mszostok added enhancement New feature or request and removed documentation Documetation is missing or incorrect labels Jun 27, 2022
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea 👍 Here are a few minor comments - it's more related to the document itself, rather than the idea, which I'm the fan of.

docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Again, nice job!

docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
docs/proposal/2022-06-14-bindings.md Outdated Show resolved Hide resolved
Copy link

@bygui86 bygui86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mszostok thanks a lot for this proposal, I love it!

@bygui86
Copy link

bygui86 commented Jul 14, 2022

@mszostok thanks for your answers :)

@mszostok mszostok changed the base branch from develop to main July 20, 2022 12:47
@mszostok mszostok merged commit 2bc724b into kubeshop:main Jul 20, 2022
@mszostok mszostok deleted the binding-proposal branch July 20, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants