Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias validation and "Show Config" button in Help #970

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Feb 3, 2023

Description

Changes proposed in this pull request:

  • Fix "Show Config" button command in Help
  • Fix alias validation: include disabled executors for validation

@pkosiec pkosiec requested review from a team and PrasadG193 as code owners February 3, 2023 13:22
@pkosiec pkosiec added the bug Something isn't working label Feb 3, 2023
@pkosiec pkosiec added this to the v0.18.0 milestone Feb 3, 2023
@pkosiec pkosiec enabled auto-merge (squash) February 3, 2023 14:29
@pkosiec pkosiec changed the title Fix show config button in help message Fix alias validation and "Show Config" button in Help Feb 3, 2023
@pkosiec pkosiec merged commit 4b44edf into kubeshop:main Feb 3, 2023
@pkosiec pkosiec deleted the fix-config-btn branch February 3, 2023 14:38
mszostok pushed a commit to mszostok/botkube that referenced this pull request Feb 3, 2023
- Fix "Show Config" button command in Help
- Fix alias validation: include disabled executors for validation
mszostok added a commit that referenced this pull request Feb 3, 2023
Fix show config button in help message (#970)

- Fix "Show Config" button command in Help
- Fix alias validation: include disabled executors for validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants