Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick fixes #971

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Cherry-pick fixes #971

merged 1 commit into from
Feb 3, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Feb 3, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Cherry-pick fixes

    • Fix "Show Config" button command in Help
    • Fix alias validation: include disabled executors for validation

@pkosiec @mszostok
Fix show config button in help message (kubeshop#970)
b0cd3c2 
- Fix "Show Config" button command in Help
- Fix alias validation: include disabled executors for validation
@mszostok mszostok requested a review from pkosiec February 3, 2023 14:39
@mszostok mszostok requested review from a team and PrasadG193 as code owners February 3, 2023 14:40
pkosiec
pkosiec approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mszostok mszostok merged commit 1361667 into kubeshop:release-0.18 Feb 3, 2023
@mszostok mszostok deleted the rel-0.18 branch February 3, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec