#564 test result page changes #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoferraro
force-pushed
the
564-test-result-page-changes
branch
from
d062686
to
396117d
Compare
|
If you can use Loom to create really quick demos, it will help me when looking at the changes to make sure everything looks right. |
xoscar
approved these changes
May 27, 2022
There was a problem hiding this comment.
Hey @cescoferraro good job! I left some non-blocking comments
| @@ -41,6 +41,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "start": "craco start", | |||
| "dev": "concurrently 'npm run start' 'npm run port-forward'", | |||
| @@ -30,7 +30,7 @@ export const SelectorListText = styled(Typography.Text).attrs({ | |||
| `; | |||
|
|
|||
| export const SpanCountText = styled(Typography.Text)` | |||
| font-size: 12; | |||
| @@ -9,18 +10,24 @@ interface IProps { | |||
| selectedType: SupportedDiagrams; | |||
| } | |||
|
|
|||
| const color = '#FFFFFF'; | |||
There was a problem hiding this comment.
Let's think about incorporating the style components theme so we don't have to hardcode colors moving forward (future work)
| @@ -80,6 +80,9 @@ const TraceDrawerHeader: React.FC<IProps> = ({ | |||
| > | |||
| Add Assertion | |||
| </S.AddAssertionButton> | |||
| <span style={{marginLeft: 16}}> | |||
There was a problem hiding this comment.
We could or not, create styled-components everytime we try to style an HTML/antd tag, let's think about that for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addreses issues raised by #564
Changes
Test are at bottom of test result should be open when you first come to the test. Currently it is closed and difficult to notice.
Show a chevron on the test result bar to indicate it can be opened & closed
Show 'Timeline view' and 'Graph view' mouseover on the buttons for switching view.
Delete assertion & Edit assertion tooltips & change delete to a trashcan icon
Remove the #de22 label from span label
Checklist