Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#564 test result page changes #579

Merged
merged 6 commits into from
May 27, 2022
Merged

#564 test result page changes #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5ae5ed
bottom of test result should be open when you first come to the test
cescoferraro May 26, 2022
9d2355f
adds dev script to call port-forward & start concurrently
cescoferraro May 26, 2022
ff8b429
Show a chevron on the test result bar to indicate it can be opened & …
cescoferraro May 26, 2022
1e13a8e
Show 'Timeline view' and 'Graph view' mouseover on the buttons for sw…
cescoferraro May 26, 2022
a4ccff1
Remove the #de22 label from span label
cescoferraro May 26, 2022
396117d
Delete assertion & Edit assertion tooltips & change delete to a trash…
cescoferraro May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
296 changes: 296 additions & 0 deletions web/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
},
"scripts": {
"start": "craco start",
"dev": "concurrently 'npm run start' 'npm run port-forward'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

"port-forward": "kubectl -n tracetest-beta port-forward svc/tracetest-beta 8080:8080",
"build": "craco build",
"test": "npm run test:unit",
Expand Down Expand Up @@ -117,6 +118,7 @@
"@types/jmespath": "0.15.0",
"@types/lodash": "4.14.181",
"@types/styled-components": "5.1.21",
"concurrently": "7.2.1",
"craco-less": "2.0.0",
"cypress": "9.6.0",
"eslint": "8.8.0",
Expand Down
3 changes: 3 additions & 0 deletions web/src/assets/chevron.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions web/src/components/AssertionCard/AssertionCard.styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {CloseCircleOutlined, EditOutlined} from '@ant-design/icons';
import {DeleteOutlined, EditOutlined} from '@ant-design/icons';
import {Tag, Typography} from 'antd';
import styled, {css} from 'styled-components';

Expand All @@ -13,7 +13,7 @@ export const Header = styled.div`
border-bottom: 1px solid rgba(3, 24, 73, 0.1);
padding: 8px 14px;
justify-content: space-between;
border-radius: 2px 2px 0px 0px;
border-radius: 2px 2px 0 0;
`;

export const Body = styled.div`
Expand All @@ -30,7 +30,7 @@ export const SelectorListText = styled(Typography.Text).attrs({
`;

export const SpanCountText = styled(Typography.Text)`
font-size: 12;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol good catch

font-size: 12px;
`;
const baseIcon = css`
font-size: 18px;
Expand All @@ -42,8 +42,8 @@ export const EditIcon = styled(EditOutlined)`
${baseIcon}
`;

export const DeleteIcon = styled(CloseCircleOutlined)`
${baseIcon}
export const DeleteIcon = styled(DeleteOutlined)`
${baseIcon};
margin-left: 12px;
`;

Expand Down
Loading