Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-17: Pipe task implementation #1105
KEP-17: Pipe task implementation #1105
Changes from 14 commits
3332621
d58e063
7b6d5f3
8848320
61dd838
3811c1a
afb47ad
a921f6c
fe78dd7
d8589a9
f8e76c9
04c5870
67b9a1e
ef7ce24
e83fc64
82be1a2
c1087ec
a6bf10e
6e38698
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like pipe keys are generated to guarantee uniques based on phase and step... but then are flatten in the template... is that true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the question but:
{{.Pipes.Mycertificate}}
in line 56 aboveSome generated files are not rendered by default. Learn more about how customized files appear on GitHub.