Use Helm-style parameters for kudoctl kudo install command

[zen-dog]

So instead of kubectl kudo install kafka -p foo,bar it would be: kubectl kudo install kafka -p foo=bar

Additionally, parameter validation is now done before the actual command execution to avoid potential failures down the road.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/component generator

/component kudoctl

/component operator
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind feature
/kind enhancement
/kind infrastructure
/kind kep

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #225

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`kudoctl kudo install` command now uses Helm-style parameters e.g. `kubectl kudo install kafka -p foo=bar`

Co-authored-by: Alena Varkockova [email protected]

[gerred]

This may be more of a Cobra and "how does my particular shell work" question, but how does this work if a value is wrapped in quotes? Does it get parsed into a string without the quotes (unless they're escaped)?

If we need to handle that detail, make sure the validate func handles it.

[fabianbaier]

lgtm but let's also aim to update the documentation https://kudo.dev/docs/cli/#install-a-package-with-instancename--parameters with this PR?

kubectl kudo install kafka --instance=my-kafka-name --parameter KAFKA_ZOOKEEPER_URI=zk-zk-0.zk-hs:2181,zk-zk-1.zk-hs:2181,zk-zk-2.zk-hs:2181 --parameter KAFKA_ZOOKEEPER_PATH=/small -p BROKERS_COUNTER=3

[gerred]

@alenkacz @zen-dog I think my comments would establish the CLI's role in parameter parsing (splitting on =) and validation of a Parameter into separate packages that can be worked with, and tested individually. Parameter could then be expanded to be the same struct as the Framework SDK and offer a lot of code re-use and richer functionality.

[fabianbaier]

This may be more of a Cobra and "how does my particular shell work" question, but how does this work if a value is wrapped in quotes? Does it get parsed into a string without the quotes (unless they're escaped)?

If we need to handle that detail, make sure the validate func handles it.

agreed, right now

-pKAFKA_ZOOKEEPER_URI=zk-zk-0.zk-hs:2181,zk-zk-1.zk-hs:2181,"zk-zk-2.zk-hs:2181"

will be parsed without the quotes.

When then (kubectl describe instance my-kafka) e.g. it would be turned into

KAFKA_ZOOKEEPER_URI: zk-zk-0.zk-hs:2181,zk-zk-1.zk-hs:2181,zk-zk-2.zk-hs:2181

Just when escaping via

--parameter KAFKA_ZOOKEEPER_URI=zk-zk-0.zk-hs:2181,zk-zk-1.zk-hs:2181,\"zk-zk-2.zk-hs:2181\"

into

KAFKA_ZOOKEEPER_URI: zk-zk-0.zk-hs:2181,zk-zk-1.zk-hs:2181,"zk-zk-2.zk-hs:2181"

you see the quotes. I like the idea of having the validate func handle this.