Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Helm-style parameters for kudoctl kudo install command #283

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Use Helm-style parameters for kudoctl kudo install command #283

merged 3 commits into from
Jun 5, 2019

Commits on Jun 3, 2019

  1. Use helm style parameters for kudoctl kudo install command. So inst… 

    …ead of:

`kubectl kudo install kafka -p foo,bar` it would be: `kubectl kudo install kafka -p foo=bar`

Additionally, parameter validation is now done before the actual command execution to avoid potential failures down the road.

Issue: #225
    @zen-dog
    zen-dog committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    2d14703 View commit details
    Browse the repository at this point in the history

  2. Fixing formatting issues

    @zen-dog
    zen-dog committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    3303a10 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Review feedback 

    - used table-driven tests for `TestTableNewInstallCmd_WithParameters`
- `validateInstallParameters` now returns all invalid parameters and not just the first one
    @zen-dog
    zen-dog committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    cd23aec View commit details
    Browse the repository at this point in the history