ci(github): move checklist to a PR #11654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can use the PR description as a commit message. Also the checklist should be checked by the reviewer. xrel Kong/team-mesh#302 Signed-off-by: Charly Molter <[email protected]>
lahabana
requested review from
bartsmykla and
lobkovilya
and removed request for
a team
Automaat
approved these changes
Oct 4, 2024
jakubdyszkiewicz
approved these changes
Oct 4, 2024
Signed-off-by: Charly Molter <[email protected]>
lahabana
added
the
ci/skip-test
lahabana
added a commit
to lahabana/kuma
that referenced
this pull request
Oct 4, 2024
xrel: kumahq#11654 Signed-off-by: Charly Molter <[email protected]>
lahabana
added a commit
that referenced
this pull request
Oct 4, 2024
xrel: #11654 Signed-off-by: Charly Molter <[email protected]>
jakubdyszkiewicz
pushed a commit
to jakubdyszkiewicz/kuma
that referenced
this pull request
Oct 4, 2024
xrel: kumahq#11654 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Jakub Dyszkiewicz <[email protected]>
lahabana
added a commit
to lahabana/kuma
that referenced
this pull request
Oct 7, 2024
xrel: kumahq#11654 kumahq#11666 Signed-off-by: Charly Molter <[email protected]>
lahabana
added a commit
to lahabana/kuma
that referenced
this pull request
Oct 7, 2024
xrel: kumahq#11654 kumahq#11666 Signed-off-by: Charly Molter <[email protected]>
lahabana
added a commit
to lahabana/kuma
that referenced
this pull request
Oct 7, 2024
It's broken and I don't have time to fix it yet xrel: kumahq#11654 kumahq#11666 kumahq#11674 Signed-off-by: Charly Molter <[email protected]>
lahabana
added a commit
that referenced
this pull request
Oct 7, 2024
It's broken and I don't have time to fix it yet xrel: #11654 #11666 #11674 Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that we can use the PR description as a commit message. Also the checklist should be checked by the reviewer.
xrel https://github.com/Kong/team-mesh/issues/302
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --